mirror of
https://github.com/torvalds/linux
synced 2024-10-16 16:29:20 +00:00
f0c7baca18
John reported that on a RK3288 system the perf per CPU interrupts are all
affine to CPU0 and provided the analysis:
"It looks like what happens is that because the interrupts are not per-CPU
in the hardware, armpmu_request_irq() calls irq_force_affinity() while
the interrupt is deactivated and then request_irq() with IRQF_PERCPU |
IRQF_NOBALANCING.
Now when irq_startup() runs with IRQ_STARTUP_NORMAL, it calls
irq_setup_affinity() which returns early because IRQF_PERCPU and
IRQF_NOBALANCING are set, leaving the interrupt on its original CPU."
This was broken by the recent commit which blocked interrupt affinity
setting in hardware before activation of the interrupt. While this works in
general, it does not work for this particular case. As contrary to the
initial analysis not all interrupt chip drivers implement an activate
callback, the safe cure is to make the deferred interrupt affinity setting
at activation time opt-in.
Implement the necessary core logic and make the two irqchip implementations
for which this is required opt-in. In hindsight this would have been the
right thing to do, but ...
Fixes:
|
||
|---|---|---|
| .. | ||
| apic.c | ||
| apic_common.c | ||
| apic_flat_64.c | ||
| apic_noop.c | ||
| apic_numachip.c | ||
| bigsmp_32.c | ||
| hw_nmi.c | ||
| io_apic.c | ||
| ipi.c | ||
| local.h | ||
| Makefile | ||
| msi.c | ||
| probe_32.c | ||
| probe_64.c | ||
| vector.c | ||
| x2apic_cluster.c | ||
| x2apic_phys.c | ||
| x2apic_uv_x.c | ||