Christoph Lameter 4e4785bcf0 [PATCH] mempolicies: fix policy_zone check ... There is a check in zonelist_policy that compares pieces of the bitmap obtained from a gfp mask via GFP_ZONETYPES with a zone number in function zonelist_policy(). The bitmap is an ORed mask of __GFP_DMA, __GFP_DMA32 and __GFP_HIGHMEM. The policy_zone is a zone number with the possible values of ZONE_DMA, ZONE_DMA32, ZONE_HIGHMEM and ZONE_NORMAL. These are two different domains of values. For some reason seemed to work before the zone reduction patchset (It definitely works on SGI boxes since we just have one zone and the check cannot fail). With the zone reduction patchset this check definitely fails on systems with two zones if the system actually has memory in both zones. This is because ZONE_NORMAL is selected using no __GFP flag at all and thus gfp_zone(gfpmask) == 0. ZONE_DMA is selected when __GFP_DMA is set. __GFP_DMA is 0x01. So gfp_zone(gfpmask) == 1. policy_zone is set to ZONE_NORMAL (==1) if ZONE_NORMAL and ZONE_DMA are populated. For ZONE_NORMAL gfp_zone(<no _GFP_DMA>) yields 0 which is < policy_zone(ZONE_NORMAL) and so policy is not applied to regular memory allocations! Instead gfp_zone(__GFP_DMA) == 1 which results in policy being applied to DMA allocations! What we realy want in that place is to establish the highest allowable zone for a given gfp_mask. If the highest zone is higher or equal to the policy_zone then memory policies need to be applied. We have such a highest_zone() function in page_alloc.c. So move the highest_zone() function from mm/page_alloc.c into include/linux/gfp.h. On the way we simplify the function and use the new zone_type that was also introduced with the zone reduction patchset plus we also specify the right type for the gfp flags parameter. Signed-off-by: Christoph Lameter <clameter@sgi.com> Signed-off-by: Lee Schermerhorn <Lee.Schermerhorn@hp.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>		2006-09-26 08:48:47 -07:00
..
bootmem.c	[PATCH] bootmem: miscellaneous coding style fixes	2006-09-26 08:48:45 -07:00
fadvise.c
filemap.c
filemap.h
filemap_xip.c
fremap.c	[PATCH] mm: small cleanup of install_page()	2006-09-26 08:48:44 -07:00
highmem.c	[PATCH] reduce MAX_NR_ZONES: move HIGHMEM counters into highmem.c/.h	2006-09-26 08:48:46 -07:00
hugetlb.c
internal.h
Kconfig
madvise.c
Makefile
memory.c	[PATCH] mm: fixup do_wp_page()	2006-09-26 08:48:44 -07:00
memory_hotplug.c
mempolicy.c	[PATCH] mempolicies: fix policy_zone check	2006-09-26 08:48:47 -07:00
mempool.c
migrate.c
mincore.c
mlock.c
mmap.c
mmzone.c
mprotect.c	[PATCH] mm: optimize the new mprotect() code a bit	2006-09-26 08:48:44 -07:00
mremap.c
msync.c	[PATCH] mm: msync() cleanup	2006-09-26 08:48:45 -07:00
nommu.c
oom_kill.c
page-writeback.c	[PATCH] mm: balance dirty pages	2006-09-26 08:48:44 -07:00
page_alloc.c	[PATCH] mempolicies: fix policy_zone check	2006-09-26 08:48:47 -07:00
page_io.c
pdflush.c
prio_tree.c
readahead.c
rmap.c
shmem.c	[PATCH] reduce MAX_NR_ZONES: move HIGHMEM counters into highmem.c/.h	2006-09-26 08:48:46 -07:00
slab.c	[PATCH] mm/: make functions static	2006-09-26 08:48:45 -07:00
slob.c
sparse.c
swap.c	[PATCH] mm/: make functions static	2006-09-26 08:48:45 -07:00
swap_state.c
swapfile.c
thrash.c
tiny-shmem.c
truncate.c
util.c
vmalloc.c	[PATCH] mm/: make functions static	2006-09-26 08:48:45 -07:00
vmscan.c
vmstat.c	[PATCH] reduce MAX_NR_ZONES: remove display of counters for unconfigured zones	2006-09-26 08:48:47 -07:00