mirror of
https://github.com/torvalds/linux
synced 2024-10-10 05:16:04 +00:00
4b53a3c721
When OCXL is enabled and HOTPLUG_PCI is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for HOTPLUG_PCI_POWERNV
Depends on [n]: PCI [=y] && HOTPLUG_PCI [=n] && PPC_POWERNV [=y] && EEH [=y]
Selected by [y]:
- OCXL [=y] && PPC_POWERNV [=y] && PCI [=y] && EEH [=y]
The reason is that OCXL selects HOTPLUG_PCI_POWERNV without depending on
or selecting HOTPLUG_PCI while HOTPLUG_PCI_POWERNV is subordinate to
HOTPLUG_PCI.
HOTPLUG_PCI_POWERNV is a visible symbol with a set of dependencies.
Selecting it will lead to overlooking its other dependencies as well.
Let OCXL depend on HOTPLUG_PCI_POWERNV instead to avoid Kbuild issues.
Fixes: 49ce94b867 ("ocxl: Add PCI hotplug dependency to Kconfig")
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Link: https://lore.kernel.org/r/20200918094148.20525-1-fazilyildiran@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
32 lines
905 B
Plaintext
32 lines
905 B
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# Open Coherent Accelerator (OCXL) compatible devices
|
|
#
|
|
|
|
config OCXL_BASE
|
|
bool
|
|
select PPC_COPRO_BASE
|
|
|
|
config OCXL
|
|
tristate "OpenCAPI coherent accelerator support"
|
|
depends on PPC_POWERNV && PCI && EEH && HOTPLUG_PCI_POWERNV
|
|
select OCXL_BASE
|
|
default m
|
|
help
|
|
Select this option to enable the ocxl driver for Open
|
|
Coherent Accelerator Processor Interface (OpenCAPI) devices.
|
|
|
|
OpenCAPI allows FPGA and ASIC accelerators to be coherently
|
|
attached to a CPU over an OpenCAPI link.
|
|
|
|
The ocxl driver enables userspace programs to access these
|
|
accelerators through devices in /dev/ocxl/.
|
|
|
|
For more information, see https://opencapi.org.
|
|
|
|
This is not to be confused with the support for IBM CAPI
|
|
accelerators (CONFIG_CXL), which are PCI-based instead of a
|
|
dedicated OpenCAPI link, and don't follow the same protocol.
|
|
|
|
If unsure, say N.
|