mirror of
https://github.com/torvalds/linux
synced 2024-10-03 09:48:02 +00:00
4a17c441c7
Somehow the existing code is not aligned with the steps described in the documentation, refactor code and make sure the register programming sequences are correct. Also add missing power-up, power-down and wake capabilities (the last two are used in follow-up patches but introduced here for consistency). Some of the SHIM registers exposed fields that are link specific, and in addition some of the power-related registers (SPA/CPA) take time to be updated. Uncontrolled access leads to timeouts or errors. Add a mutex, shared by all links, so that all accesses to such registers are serialized, and follow a pattern of read-modify-write. This includes making sure SHIM_SYNC is programmed only once, before the first master is powered on. We use a 'shim_mask' field, shared between all links and protected by a mutex, to deal with power-up and power-down sequences. Note that the SYNCPRD value is tied only to the XTAL value and not the current bus frequency or the frame rate. BugLink: https://github.com/thesofproject/linux/issues/1555 Signed-off-by: Rander Wang <rander.wang@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Link: https://lore.kernel.org/r/20200716150947.22119-3-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
48 lines
1.3 KiB
C
48 lines
1.3 KiB
C
/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
|
|
/* Copyright(c) 2015-17 Intel Corporation. */
|
|
|
|
#ifndef __SDW_INTEL_LOCAL_H
|
|
#define __SDW_INTEL_LOCAL_H
|
|
|
|
/**
|
|
* struct sdw_intel_link_res - Soundwire Intel link resource structure,
|
|
* typically populated by the controller driver.
|
|
* @pdev: platform_device
|
|
* @mmio_base: mmio base of SoundWire registers
|
|
* @registers: Link IO registers base
|
|
* @shim: Audio shim pointer
|
|
* @alh: ALH (Audio Link Hub) pointer
|
|
* @irq: Interrupt line
|
|
* @ops: Shim callback ops
|
|
* @dev: device implementing hw_params and free callbacks
|
|
* @shim_lock: mutex to handle access to shared SHIM registers
|
|
* @shim_mask: global pointer to check SHIM register initialization
|
|
*/
|
|
struct sdw_intel_link_res {
|
|
struct platform_device *pdev;
|
|
void __iomem *mmio_base; /* not strictly needed, useful for debug */
|
|
void __iomem *registers;
|
|
void __iomem *shim;
|
|
void __iomem *alh;
|
|
int irq;
|
|
const struct sdw_intel_ops *ops;
|
|
struct device *dev;
|
|
struct mutex *shim_lock; /* protect shared registers */
|
|
u32 *shim_mask;
|
|
};
|
|
|
|
struct sdw_intel {
|
|
struct sdw_cdns cdns;
|
|
int instance;
|
|
struct sdw_intel_link_res *link_res;
|
|
#ifdef CONFIG_DEBUG_FS
|
|
struct dentry *debugfs;
|
|
#endif
|
|
};
|
|
|
|
#define SDW_INTEL_QUIRK_MASK_BUS_DISABLE BIT(1)
|
|
|
|
int intel_master_startup(struct platform_device *pdev);
|
|
|
|
#endif /* __SDW_INTEL_LOCAL_H */
|