mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
![Jakub Kicinski](/assets/img/avatar_default.png)
ethnl_default_dump_one() passes NULL as info.
It's correct not to set extack during dump, as we should just
silently skip interfaces which can't provide the information.
Reported-by: syzbot+81c4b4bbba6eea2cfcae@syzkaller.appspotmail.com
Fixes: 18ff0bcda6
("ethtool: add interface to interact with Ethernet Power Equipment")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
186 lines
4.6 KiB
C
186 lines
4.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
//
|
|
// ethtool interface for for Ethernet PSE (Power Sourcing Equipment)
|
|
// and PD (Powered Device)
|
|
//
|
|
// Copyright (c) 2022 Pengutronix, Oleksij Rempel <kernel@pengutronix.de>
|
|
//
|
|
|
|
#include "common.h"
|
|
#include "linux/pse-pd/pse.h"
|
|
#include "netlink.h"
|
|
#include <linux/ethtool_netlink.h>
|
|
#include <linux/ethtool.h>
|
|
#include <linux/phy.h>
|
|
|
|
struct pse_req_info {
|
|
struct ethnl_req_info base;
|
|
};
|
|
|
|
struct pse_reply_data {
|
|
struct ethnl_reply_data base;
|
|
struct pse_control_status status;
|
|
};
|
|
|
|
#define PSE_REPDATA(__reply_base) \
|
|
container_of(__reply_base, struct pse_reply_data, base)
|
|
|
|
/* PSE_GET */
|
|
|
|
const struct nla_policy ethnl_pse_get_policy[ETHTOOL_A_PSE_HEADER + 1] = {
|
|
[ETHTOOL_A_PSE_HEADER] = NLA_POLICY_NESTED(ethnl_header_policy),
|
|
};
|
|
|
|
static int pse_get_pse_attributes(struct net_device *dev,
|
|
struct netlink_ext_ack *extack,
|
|
struct pse_reply_data *data)
|
|
{
|
|
struct phy_device *phydev = dev->phydev;
|
|
|
|
if (!phydev) {
|
|
NL_SET_ERR_MSG(extack, "No PHY is attached");
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
if (!phydev->psec) {
|
|
NL_SET_ERR_MSG(extack, "No PSE is attached");
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
memset(&data->status, 0, sizeof(data->status));
|
|
|
|
return pse_ethtool_get_status(phydev->psec, extack, &data->status);
|
|
}
|
|
|
|
static int pse_prepare_data(const struct ethnl_req_info *req_base,
|
|
struct ethnl_reply_data *reply_base,
|
|
struct genl_info *info)
|
|
{
|
|
struct pse_reply_data *data = PSE_REPDATA(reply_base);
|
|
struct net_device *dev = reply_base->dev;
|
|
int ret;
|
|
|
|
ret = ethnl_ops_begin(dev);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = pse_get_pse_attributes(dev, info ? info->extack : NULL, data);
|
|
|
|
ethnl_ops_complete(dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int pse_reply_size(const struct ethnl_req_info *req_base,
|
|
const struct ethnl_reply_data *reply_base)
|
|
{
|
|
const struct pse_reply_data *data = PSE_REPDATA(reply_base);
|
|
const struct pse_control_status *st = &data->status;
|
|
int len = 0;
|
|
|
|
if (st->podl_admin_state > 0)
|
|
len += nla_total_size(sizeof(u32)); /* _PODL_PSE_ADMIN_STATE */
|
|
if (st->podl_pw_status > 0)
|
|
len += nla_total_size(sizeof(u32)); /* _PODL_PSE_PW_D_STATUS */
|
|
|
|
return len;
|
|
}
|
|
|
|
static int pse_fill_reply(struct sk_buff *skb,
|
|
const struct ethnl_req_info *req_base,
|
|
const struct ethnl_reply_data *reply_base)
|
|
{
|
|
const struct pse_reply_data *data = PSE_REPDATA(reply_base);
|
|
const struct pse_control_status *st = &data->status;
|
|
|
|
if (st->podl_admin_state > 0 &&
|
|
nla_put_u32(skb, ETHTOOL_A_PODL_PSE_ADMIN_STATE,
|
|
st->podl_admin_state))
|
|
return -EMSGSIZE;
|
|
|
|
if (st->podl_pw_status > 0 &&
|
|
nla_put_u32(skb, ETHTOOL_A_PODL_PSE_PW_D_STATUS,
|
|
st->podl_pw_status))
|
|
return -EMSGSIZE;
|
|
|
|
return 0;
|
|
}
|
|
|
|
const struct ethnl_request_ops ethnl_pse_request_ops = {
|
|
.request_cmd = ETHTOOL_MSG_PSE_GET,
|
|
.reply_cmd = ETHTOOL_MSG_PSE_GET_REPLY,
|
|
.hdr_attr = ETHTOOL_A_PSE_HEADER,
|
|
.req_info_size = sizeof(struct pse_req_info),
|
|
.reply_data_size = sizeof(struct pse_reply_data),
|
|
|
|
.prepare_data = pse_prepare_data,
|
|
.reply_size = pse_reply_size,
|
|
.fill_reply = pse_fill_reply,
|
|
};
|
|
|
|
/* PSE_SET */
|
|
|
|
const struct nla_policy ethnl_pse_set_policy[ETHTOOL_A_PSE_MAX + 1] = {
|
|
[ETHTOOL_A_PSE_HEADER] = NLA_POLICY_NESTED(ethnl_header_policy),
|
|
[ETHTOOL_A_PODL_PSE_ADMIN_CONTROL] =
|
|
NLA_POLICY_RANGE(NLA_U32, ETHTOOL_PODL_PSE_ADMIN_STATE_DISABLED,
|
|
ETHTOOL_PODL_PSE_ADMIN_STATE_ENABLED),
|
|
};
|
|
|
|
static int pse_set_pse_config(struct net_device *dev,
|
|
struct netlink_ext_ack *extack,
|
|
struct nlattr **tb)
|
|
{
|
|
struct phy_device *phydev = dev->phydev;
|
|
struct pse_control_config config = {};
|
|
|
|
/* Optional attribute. Do not return error if not set. */
|
|
if (!tb[ETHTOOL_A_PODL_PSE_ADMIN_CONTROL])
|
|
return 0;
|
|
|
|
/* this values are already validated by the ethnl_pse_set_policy */
|
|
config.admin_cotrol = nla_get_u32(tb[ETHTOOL_A_PODL_PSE_ADMIN_CONTROL]);
|
|
|
|
if (!phydev) {
|
|
NL_SET_ERR_MSG(extack, "No PHY is attached");
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
if (!phydev->psec) {
|
|
NL_SET_ERR_MSG(extack, "No PSE is attached");
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
return pse_ethtool_set_config(phydev->psec, extack, &config);
|
|
}
|
|
|
|
int ethnl_set_pse(struct sk_buff *skb, struct genl_info *info)
|
|
{
|
|
struct ethnl_req_info req_info = {};
|
|
struct nlattr **tb = info->attrs;
|
|
struct net_device *dev;
|
|
int ret;
|
|
|
|
ret = ethnl_parse_header_dev_get(&req_info, tb[ETHTOOL_A_PSE_HEADER],
|
|
genl_info_net(info), info->extack,
|
|
true);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
dev = req_info.dev;
|
|
|
|
rtnl_lock();
|
|
ret = ethnl_ops_begin(dev);
|
|
if (ret < 0)
|
|
goto out_rtnl;
|
|
|
|
ret = pse_set_pse_config(dev, info->extack, tb);
|
|
ethnl_ops_complete(dev);
|
|
out_rtnl:
|
|
rtnl_unlock();
|
|
|
|
ethnl_parse_header_dev_put(&req_info);
|
|
|
|
return ret;
|
|
}
|