mirror of
https://github.com/torvalds/linux
synced 2024-07-21 02:23:16 +00:00
259b93b21a
Probing of regulators can be a slow operation and can contribute to slower boot times. This is especially true if a regulator is turned on at probe time (with regulator-boot-on or regulator-always-on) and the regulator requires delays (off-on-time, ramp time, etc). While the overall kernel is not ready to switch to async probe by default, as per the discussion on the mailing lists [1] it is believed that the regulator subsystem is in good shape and we can move regulator drivers over wholesale. There is no way to just magically opt in all regulators (regulators are just normal drivers like platform_driver), so we set PROBE_PREFER_ASYNCHRONOUS for all regulators found in 'drivers/regulator' individually. Given the number of drivers touched and the impossibility to test this ahead of time, it wouldn't be shocking at all if this caused a regression for someone. If there is a regression caused by this patch, it's likely to be one of the cases talked about in [1]. As a "quick fix", drivers involved in the regression could be fixed by changing them to PROBE_FORCE_SYNCHRONOUS. That being said, the correct fix would be to directly fix the problem that caused the issue with async probe. The approach here follows a similar approach that was used for the mmc subsystem several years ago [2]. In fact, I ran nearly the same python script to auto-generate the changes. The only thing I changed was to search for "i2c_driver", "spmi_driver", and "spi_driver" in addition to "platform_driver". [1] https://lore.kernel.org/r/06db017f-e985-4434-8d1d-02ca2100cca0@sirena.org.uk [2] https://lore.kernel.org/r/20200903232441.2694866-1-dianders@chromium.org/ Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20230316125351.1.I2a4677392a38db5758dee0788b2cea5872562a82@changeid Signed-off-by: Mark Brown <broonie@kernel.org>
137 lines
3.9 KiB
C
137 lines
3.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Regulator driver for the Richtek RT5033
|
|
*
|
|
* Copyright (C) 2014 Samsung Electronics, Co., Ltd.
|
|
* Author: Beomho Seo <beomho.seo@samsung.com>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regulator/driver.h>
|
|
#include <linux/mfd/rt5033.h>
|
|
#include <linux/mfd/rt5033-private.h>
|
|
#include <linux/regulator/of_regulator.h>
|
|
|
|
static const struct linear_range rt5033_buck_ranges[] = {
|
|
REGULATOR_LINEAR_RANGE(1000000, 0, 20, 100000),
|
|
REGULATOR_LINEAR_RANGE(3000000, 21, 31, 0),
|
|
};
|
|
|
|
static const struct linear_range rt5033_ldo_ranges[] = {
|
|
REGULATOR_LINEAR_RANGE(1200000, 0, 18, 100000),
|
|
REGULATOR_LINEAR_RANGE(3000000, 19, 31, 0),
|
|
};
|
|
|
|
static const struct regulator_ops rt5033_safe_ldo_ops = {
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
.enable = regulator_enable_regmap,
|
|
.disable = regulator_disable_regmap,
|
|
.list_voltage = regulator_list_voltage_linear,
|
|
};
|
|
|
|
static const struct regulator_ops rt5033_buck_ops = {
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
.enable = regulator_enable_regmap,
|
|
.disable = regulator_disable_regmap,
|
|
.list_voltage = regulator_list_voltage_linear_range,
|
|
.get_voltage_sel = regulator_get_voltage_sel_regmap,
|
|
.set_voltage_sel = regulator_set_voltage_sel_regmap,
|
|
};
|
|
|
|
static const struct regulator_desc rt5033_supported_regulators[] = {
|
|
[RT5033_BUCK] = {
|
|
.name = "BUCK",
|
|
.of_match = of_match_ptr("BUCK"),
|
|
.regulators_node = of_match_ptr("regulators"),
|
|
.id = RT5033_BUCK,
|
|
.ops = &rt5033_buck_ops,
|
|
.type = REGULATOR_VOLTAGE,
|
|
.owner = THIS_MODULE,
|
|
.n_voltages = RT5033_REGULATOR_BUCK_VOLTAGE_STEP_NUM,
|
|
.linear_ranges = rt5033_buck_ranges,
|
|
.n_linear_ranges = ARRAY_SIZE(rt5033_buck_ranges),
|
|
.enable_reg = RT5033_REG_CTRL,
|
|
.enable_mask = RT5033_CTRL_EN_BUCK_MASK,
|
|
.vsel_reg = RT5033_REG_BUCK_CTRL,
|
|
.vsel_mask = RT5033_BUCK_CTRL_MASK,
|
|
},
|
|
[RT5033_LDO] = {
|
|
.name = "LDO",
|
|
.of_match = of_match_ptr("LDO"),
|
|
.regulators_node = of_match_ptr("regulators"),
|
|
.id = RT5033_LDO,
|
|
.ops = &rt5033_buck_ops,
|
|
.type = REGULATOR_VOLTAGE,
|
|
.owner = THIS_MODULE,
|
|
.n_voltages = RT5033_REGULATOR_LDO_VOLTAGE_STEP_NUM,
|
|
.linear_ranges = rt5033_ldo_ranges,
|
|
.n_linear_ranges = ARRAY_SIZE(rt5033_ldo_ranges),
|
|
.enable_reg = RT5033_REG_CTRL,
|
|
.enable_mask = RT5033_CTRL_EN_LDO_MASK,
|
|
.vsel_reg = RT5033_REG_LDO_CTRL,
|
|
.vsel_mask = RT5033_LDO_CTRL_MASK,
|
|
},
|
|
[RT5033_SAFE_LDO] = {
|
|
.name = "SAFE_LDO",
|
|
.of_match = of_match_ptr("SAFE_LDO"),
|
|
.regulators_node = of_match_ptr("regulators"),
|
|
.id = RT5033_SAFE_LDO,
|
|
.ops = &rt5033_safe_ldo_ops,
|
|
.type = REGULATOR_VOLTAGE,
|
|
.owner = THIS_MODULE,
|
|
.n_voltages = 1,
|
|
.min_uV = RT5033_REGULATOR_SAFE_LDO_VOLTAGE,
|
|
.enable_reg = RT5033_REG_CTRL,
|
|
.enable_mask = RT5033_CTRL_EN_SAFE_LDO_MASK,
|
|
},
|
|
};
|
|
|
|
static int rt5033_regulator_probe(struct platform_device *pdev)
|
|
{
|
|
struct rt5033_dev *rt5033 = dev_get_drvdata(pdev->dev.parent);
|
|
int ret, i;
|
|
struct regulator_config config = {};
|
|
|
|
config.dev = rt5033->dev;
|
|
config.driver_data = rt5033;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(rt5033_supported_regulators); i++) {
|
|
struct regulator_dev *regulator;
|
|
|
|
config.regmap = rt5033->regmap;
|
|
|
|
regulator = devm_regulator_register(&pdev->dev,
|
|
&rt5033_supported_regulators[i], &config);
|
|
if (IS_ERR(regulator)) {
|
|
ret = PTR_ERR(regulator);
|
|
dev_err(&pdev->dev,
|
|
"Regulator init failed %d: with error: %d\n",
|
|
i, ret);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct platform_device_id rt5033_regulator_id[] = {
|
|
{ "rt5033-regulator", },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(platform, rt5033_regulator_id);
|
|
|
|
static struct platform_driver rt5033_regulator_driver = {
|
|
.driver = {
|
|
.name = "rt5033-regulator",
|
|
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
|
|
},
|
|
.probe = rt5033_regulator_probe,
|
|
.id_table = rt5033_regulator_id,
|
|
};
|
|
module_platform_driver(rt5033_regulator_driver);
|
|
|
|
MODULE_DESCRIPTION("Richtek RT5033 Regulator driver");
|
|
MODULE_AUTHOR("Beomho Seo <beomho.seo@samsung.com>");
|
|
MODULE_LICENSE("GPL");
|