linux/drivers/regulator/max77541-regulator.c
Chen-Yu Tsai 269cb04b60
regulator: Use bitfield values for range selectors
Right now the regulator helpers expect raw register values for the range
selectors. This is different from the voltage selectors, which are
normalized as bitfield values. This leads to a bit of confusion. Also,
raw values are harder to copy from datasheets or match up with them,
as datasheets will typically have bitfield values.

Make the helpers expect bitfield values, and convert existing users. The
field in regulator_desc is renamed to |linear_range_selectors_bitfield|.
This is intended to cause drivers added in the same merge window and
out-of-tree drivers using the incorrect variable and values to break,
preventing incorrect values being used on actual hardware and potentially
producing magic smoke.

Also include bitops.h explicitly for ffs(), and reorder the header include
statements. While at it, also replace module.h with export.h, since the
only use is EXPORT_SYMBOL_GPL.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20230714081408.274567-1-wenst@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
2023-07-25 12:14:27 +01:00

154 lines
4.8 KiB
C

// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2022 Analog Devices, Inc.
* ADI Regulator driver for the MAX77540 and MAX77541
*/
#include <linux/mfd/max77541.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/regulator/driver.h>
static const struct regulator_ops max77541_buck_ops = {
.enable = regulator_enable_regmap,
.disable = regulator_disable_regmap,
.is_enabled = regulator_is_enabled_regmap,
.list_voltage = regulator_list_voltage_pickable_linear_range,
.get_voltage_sel = regulator_get_voltage_sel_pickable_regmap,
.set_voltage_sel = regulator_set_voltage_sel_pickable_regmap,
};
static const struct linear_range max77540_buck_ranges[] = {
/* Ranges when VOLT_SEL bits are 0x00 */
REGULATOR_LINEAR_RANGE(500000, 0x00, 0x8B, 5000),
REGULATOR_LINEAR_RANGE(1200000, 0x8C, 0xFF, 0),
/* Ranges when VOLT_SEL bits are 0x40 */
REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x8B, 10000),
REGULATOR_LINEAR_RANGE(2400000, 0x8C, 0xFF, 0),
/* Ranges when VOLT_SEL bits are 0x80 */
REGULATOR_LINEAR_RANGE(2000000, 0x00, 0x9F, 20000),
REGULATOR_LINEAR_RANGE(5200000, 0xA0, 0xFF, 0),
};
static const struct linear_range max77541_buck_ranges[] = {
/* Ranges when VOLT_SEL bits are 0x00 */
REGULATOR_LINEAR_RANGE(300000, 0x00, 0xB3, 5000),
REGULATOR_LINEAR_RANGE(1200000, 0xB4, 0xFF, 0),
/* Ranges when VOLT_SEL bits are 0x40 */
REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x8B, 10000),
REGULATOR_LINEAR_RANGE(2400000, 0x8C, 0xFF, 0),
/* Ranges when VOLT_SEL bits are 0x80 */
REGULATOR_LINEAR_RANGE(2000000, 0x00, 0x9F, 20000),
REGULATOR_LINEAR_RANGE(5200000, 0xA0, 0xFF, 0),
};
static const unsigned int max77541_buck_volt_range_sel[] = {
0x0, 0x0, 0x1, 0x1, 0x2, 0x2,
};
enum max77541_regulators {
MAX77541_BUCK1 = 1,
MAX77541_BUCK2,
};
#define MAX77540_BUCK(_id, _ops) \
{ .id = MAX77541_BUCK ## _id, \
.name = "buck"#_id, \
.of_match = "buck"#_id, \
.regulators_node = "regulators", \
.enable_reg = MAX77541_REG_EN_CTRL, \
.enable_mask = MAX77541_BIT_M ## _id ## _EN, \
.ops = &(_ops), \
.type = REGULATOR_VOLTAGE, \
.linear_ranges = max77540_buck_ranges, \
.n_linear_ranges = ARRAY_SIZE(max77540_buck_ranges), \
.vsel_reg = MAX77541_REG_M ## _id ## _VOUT, \
.vsel_mask = MAX77541_BITS_MX_VOUT, \
.vsel_range_reg = MAX77541_REG_M ## _id ## _CFG1, \
.vsel_range_mask = MAX77541_BITS_MX_CFG1_RNG, \
.linear_range_selectors_bitfield = max77541_buck_volt_range_sel, \
.owner = THIS_MODULE, \
}
#define MAX77541_BUCK(_id, _ops) \
{ .id = MAX77541_BUCK ## _id, \
.name = "buck"#_id, \
.of_match = "buck"#_id, \
.regulators_node = "regulators", \
.enable_reg = MAX77541_REG_EN_CTRL, \
.enable_mask = MAX77541_BIT_M ## _id ## _EN, \
.ops = &(_ops), \
.type = REGULATOR_VOLTAGE, \
.linear_ranges = max77541_buck_ranges, \
.n_linear_ranges = ARRAY_SIZE(max77541_buck_ranges), \
.vsel_reg = MAX77541_REG_M ## _id ## _VOUT, \
.vsel_mask = MAX77541_BITS_MX_VOUT, \
.vsel_range_reg = MAX77541_REG_M ## _id ## _CFG1, \
.vsel_range_mask = MAX77541_BITS_MX_CFG1_RNG, \
.linear_range_selectors_bitfield = max77541_buck_volt_range_sel, \
.owner = THIS_MODULE, \
}
static const struct regulator_desc max77540_regulators_desc[] = {
MAX77540_BUCK(1, max77541_buck_ops),
MAX77540_BUCK(2, max77541_buck_ops),
};
static const struct regulator_desc max77541_regulators_desc[] = {
MAX77541_BUCK(1, max77541_buck_ops),
MAX77541_BUCK(2, max77541_buck_ops),
};
static int max77541_regulator_probe(struct platform_device *pdev)
{
struct regulator_config config = {};
const struct regulator_desc *desc;
struct device *dev = &pdev->dev;
struct regulator_dev *rdev;
struct max77541 *max77541 = dev_get_drvdata(dev->parent);
unsigned int i;
config.dev = dev->parent;
switch (max77541->id) {
case MAX77540:
desc = max77540_regulators_desc;
break;
case MAX77541:
desc = max77541_regulators_desc;
break;
default:
return -EINVAL;
}
for (i = 0; i < MAX77541_MAX_REGULATORS; i++) {
rdev = devm_regulator_register(dev, &desc[i], &config);
if (IS_ERR(rdev))
return dev_err_probe(dev, PTR_ERR(rdev),
"Failed to register regulator\n");
}
return 0;
}
static const struct platform_device_id max77541_regulator_platform_id[] = {
{ "max77540-regulator" },
{ "max77541-regulator" },
{ }
};
MODULE_DEVICE_TABLE(platform, max77541_regulator_platform_id);
static struct platform_driver max77541_regulator_driver = {
.driver = {
.name = "max77541-regulator",
},
.probe = max77541_regulator_probe,
.id_table = max77541_regulator_platform_id,
};
module_platform_driver(max77541_regulator_driver);
MODULE_AUTHOR("Okan Sahin <Okan.Sahin@analog.com>");
MODULE_DESCRIPTION("MAX77540/MAX77541 regulator driver");
MODULE_LICENSE("GPL");