mirror of
https://github.com/torvalds/linux
synced 2024-07-22 03:01:14 +00:00
fef419c463
Requests sent to RPMH can be sent as fire-n-forget or response required, with the latter ensuring the command has been completed by the hardware accelerator. Commands in a request with tcs_cmd::wait set, would ensure that those select commands are sent as response required, even though the actual TCS request may be fire-n-forget. Also, commands with .wait flag were also guaranteed to be complete before the following command in the TCS is sent. This means that the next command of the same request blocked until the current request is completed. This could mean waiting for a voltage to settle or series of NOCs be configured before the next command is sent. But drivers using this feature have never cared about the serialization aspect. By not enforcing the serialization we can allow the hardware to run in parallel improving the performance. Let's clarify the usage of this member in the tcs_cmd structure to mean only completion and not serialization. This should also improve the performance of bus requests where changes could happen in parallel. Also, CPU resume from deep idle may see benefits from certain wake requests. Reviewed-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Lina Iyer <ilina@codeaurora.org> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> Link: https://lore.kernel.org/r/1610008770-13891-1-git-send-email-mkshah@codeaurora.org Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
82 lines
2.6 KiB
C
82 lines
2.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2016-2019, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#ifndef __SOC_QCOM_TCS_H__
|
|
#define __SOC_QCOM_TCS_H__
|
|
|
|
#define MAX_RPMH_PAYLOAD 16
|
|
|
|
/**
|
|
* rpmh_state: state for the request
|
|
*
|
|
* RPMH_SLEEP_STATE: State of the resource when the processor subsystem
|
|
* is powered down. There is no client using the
|
|
* resource actively.
|
|
* RPMH_WAKE_ONLY_STATE: Resume resource state to the value previously
|
|
* requested before the processor was powered down.
|
|
* RPMH_ACTIVE_ONLY_STATE: Active or AMC mode requests. Resource state
|
|
* is aggregated immediately.
|
|
*/
|
|
enum rpmh_state {
|
|
RPMH_SLEEP_STATE,
|
|
RPMH_WAKE_ONLY_STATE,
|
|
RPMH_ACTIVE_ONLY_STATE,
|
|
};
|
|
|
|
/**
|
|
* struct tcs_cmd: an individual request to RPMH.
|
|
*
|
|
* @addr: the address of the resource slv_id:18:16 | offset:0:15
|
|
* @data: the resource state request
|
|
* @wait: ensure that this command is complete before returning.
|
|
* Setting "wait" here only makes sense during rpmh_write_batch() for
|
|
* active-only transfers, this is because:
|
|
* rpmh_write() - Always waits.
|
|
* (DEFINE_RPMH_MSG_ONSTACK will set .wait_for_compl)
|
|
* rpmh_write_async() - Never waits.
|
|
* (There's no request completion callback)
|
|
*/
|
|
struct tcs_cmd {
|
|
u32 addr;
|
|
u32 data;
|
|
u32 wait;
|
|
};
|
|
|
|
/**
|
|
* struct tcs_request: A set of tcs_cmds sent together in a TCS
|
|
*
|
|
* @state: state for the request.
|
|
* @wait_for_compl: wait until we get a response from the h/w accelerator
|
|
* (same as setting cmd->wait for all commands in the request)
|
|
* @num_cmds: the number of @cmds in this request
|
|
* @cmds: an array of tcs_cmds
|
|
*/
|
|
struct tcs_request {
|
|
enum rpmh_state state;
|
|
u32 wait_for_compl;
|
|
u32 num_cmds;
|
|
struct tcs_cmd *cmds;
|
|
};
|
|
|
|
#define BCM_TCS_CMD_COMMIT_SHFT 30
|
|
#define BCM_TCS_CMD_COMMIT_MASK 0x40000000
|
|
#define BCM_TCS_CMD_VALID_SHFT 29
|
|
#define BCM_TCS_CMD_VALID_MASK 0x20000000
|
|
#define BCM_TCS_CMD_VOTE_X_SHFT 14
|
|
#define BCM_TCS_CMD_VOTE_MASK 0x3fff
|
|
#define BCM_TCS_CMD_VOTE_Y_SHFT 0
|
|
#define BCM_TCS_CMD_VOTE_Y_MASK 0xfffc000
|
|
|
|
/* Construct a Bus Clock Manager (BCM) specific TCS command */
|
|
#define BCM_TCS_CMD(commit, valid, vote_x, vote_y) \
|
|
(((commit) << BCM_TCS_CMD_COMMIT_SHFT) | \
|
|
((valid) << BCM_TCS_CMD_VALID_SHFT) | \
|
|
((cpu_to_le32(vote_x) & \
|
|
BCM_TCS_CMD_VOTE_MASK) << BCM_TCS_CMD_VOTE_X_SHFT) | \
|
|
((cpu_to_le32(vote_y) & \
|
|
BCM_TCS_CMD_VOTE_MASK) << BCM_TCS_CMD_VOTE_Y_SHFT))
|
|
|
|
#endif /* __SOC_QCOM_TCS_H__ */
|