linux/drivers/message/fusion
Joe Lawrence 9f21316fc2 mptfusion: tweak null pointer checks
Fixes the following smatch warnings:

  drivers/message/fusion/mptbase.c:652 mptbase_reply() warn: variable
    dereferenced before check 'reply' (see line 639)

      [JL: No-brainer, the enclosing switch statement dereferences
       reply, so we can't get here unless reply is valid.]

  drivers/message/fusion/mptsas.c:1255 mptsas_taskmgmt_complete() error:
    we previously assumed 'pScsiTmReply' could be null (see line 1227)

      [HCH: Reading the code in mptsas_taskmgmt_complete it's pretty
       obvious that it can't do anything useful if mr/pScsiTmReply are
       NULL, so I suspect it would be best to just return at the
       beginning of the function.

       I'd love to understand if it actually could ever be zero, which I
       doubt.  Maybe the LSI people can shed some light on that?]

  drivers/message/fusion/mptsas.c:3888 mptsas_not_responding_devices()
    error: we previously assumed 'port_info->phy_info' could be null
    (see line 3875)

      [HCH: It's pretty obvious from reading mptsas_sas_io_unit_pg0 that
       we never register a port_info with a NULL phy_info in the lists,
       so all NULL checks on it could be deleted.]

  drivers/message/fusion/mptscsih.c:1284 mptscsih_info() error:
    we previously assumed 'h' could be null (see line 1274)

      [HCH: shost_priv can't return NULL, so the if (h) should be
       removed.]

  drivers/message/fusion/mptscsih.c:1388 mptscsih_qcmd() error: we
    previously assumed 'vdevice' could be null (see line 1373)

      [HCH: vdevice can't ever be NULL here, it's allocated in
       ->slave_alloc and thus guaranteed to be around when
       ->queuecommand is called.]

Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
Acked-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2014-07-25 17:16:58 -04:00
..
lsi SCSI updates for post 3.2 merge window 2012-01-10 10:36:08 -08:00
Kconfig [SCSI] mpt fusion: Kconfig cleanup 2007-10-12 14:48:53 -04:00
Makefile message: change to new flag variable 2011-03-17 14:05:34 +01:00
mptbase.c mptfusion: tweak null pointer checks 2014-07-25 17:16:58 -04:00
mptbase.h mptfusion: make adapter prod_name[] a pointer 2014-07-25 17:16:58 -04:00
mptctl.c mptfusion: use memdup_user 2014-07-25 17:16:57 -04:00
mptctl.h [SCSI] mpt fusion : Updated copyright statment with 2008 included 2008-06-05 09:27:17 -05:00
mptdebug.h [SCSI] mpt fusion: Fixing 1078 data corruption issue for 36GB memory region 2009-06-09 17:21:31 -05:00
mptfc.c mptfusion: remove redundant kfree checks 2014-07-25 17:16:57 -04:00
mptlan.c [SCSI] mptfusion: Extra debug prints added relavent to Device missing delay error handling 2010-07-28 09:07:47 -05:00
mptlan.h tokenring: delete all remaining driver support 2012-05-15 20:23:16 -04:00
mptsas.c mptfusion: tweak null pointer checks 2014-07-25 17:16:58 -04:00
mptsas.h mptfusion: combine fw_event_work and its event_data 2014-07-25 17:16:58 -04:00
mptscsih.c mptfusion: tweak null pointer checks 2014-07-25 17:16:58 -04:00
mptscsih.h scsi: use 64-bit LUNs 2014-07-17 22:07:37 +02:00
mptspi.c mptfusion: remove redundant kfree checks 2014-07-25 17:16:57 -04:00