Yuan Can 48ecee6159 media: platform: exynos4-is: Fix error handling in fimc_md_init() ... A problem about modprobe s5p_fimc failed is triggered with the following log given: [ 272.075275] Error: Driver 'exynos4-fimc' is already registered, aborting... modprobe: ERROR: could not insert 's5p_fimc': Device or resource busy The reason is that fimc_md_init() returns platform_driver_register() directly without checking its return value, if platform_driver_register() failed, it returns without unregister fimc_driver, resulting the s5p_fimc can never be installed later. A simple call graph is shown as below: fimc_md_init() fimc_register_driver() # register fimc_driver platform_driver_register() platform_driver_register() driver_register() bus_add_driver() dev = kzalloc(...) # OOM happened # return without unregister fimc_driver Fix by unregister fimc_driver when platform_driver_register() returns error. Fixes: d3953223b0 ("[media] s5p-fimc: Add the media device driver") Signed-off-by: Yuan Can <yuancan@huawei.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>		2022-11-25 07:37:53 +00:00
..
exynos-gsc	media: platform: exynos-gsc: fix typo in comment	2022-06-20 10:30:35 +01:00
exynos4-is	media: platform: exynos4-is: Fix error handling in fimc_md_init()	2022-11-25 07:37:53 +00:00
s3c-camif	media: mc: convert pipeline funcs to take media_pad	2022-09-24 09:22:30 +02:00
s5p-g2d	media: Kconfig: cleanup VIDEO_DEV dependencies	2022-03-18 05:58:35 +01:00
s5p-jpeg	media: platform: samsung: s5p-jpeg: replace ternary operator with max()	2022-06-20 10:30:31 +01:00
s5p-mfc	media: s5p-mfc: Optimisation of code to remove error message	2022-11-25 07:34:40 +00:00
Kconfig	media: platform/*/Kconfig: make manufacturer menus more uniform	2022-03-18 05:58:35 +01:00
Makefile	media: platform: Create vendor/{Makefile,Kconfig} files	2022-03-18 05:58:35 +01:00