linux/drivers/net/ethernet/sun
Peter Senna Tschudin 4df128341e drivers/net/ethernet/sun/sungem.c: fix error return code
The function gem_init_one() return 0 for success and negative value
for most of its internal tests failures. There is one exception
that is error case going to err_out_free_consistent:. For this error
case, the function abort its success execution path, but returns non
negative value, making it difficult for a caller function to notice
the error.

This patch fixes the error case that do not return negative value.

This was found by Coccinelle, but the code change was made by hand.
This patch is not robot generated.

A simplified version of the semantic match that finds this problem is
as follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-10-07 14:37:12 -04:00
..
cassini.c workqueue: deprecate flush[_delayed]_work_sync() 2012-08-20 14:51:24 -07:00
cassini.h
Kconfig
Makefile
niu.c drivers/net/ethernet/sun/niu.c: fix error return code 2012-10-07 14:37:12 -04:00
niu.h
sunbmac.c sunbmac: Remove unused local variable. 2012-09-21 15:23:12 -04:00
sunbmac.h
sungem.c drivers/net/ethernet/sun/sungem.c: fix error return code 2012-10-07 14:37:12 -04:00
sungem.h
sunhme.c sunhme: remove unnecessary setting of skb->dev 2012-07-10 23:24:57 -07:00
sunhme.h sunhme: stop using net_device.{base_addr, irq}. 2012-04-07 11:47:03 +02:00
sunqe.c ethernet: Remove casts to same type 2012-06-06 09:31:33 -07:00
sunqe.h
sunvnet.c drivers/net: Convert compare_ether_addr to ether_addr_equal 2012-05-10 23:33:01 -04:00
sunvnet.h