mirror of
https://github.com/torvalds/linux
synced 2024-10-10 05:16:04 +00:00
80140b71e0
The p54 driver uses request_firmware() twice, once for actual
firmware and then another time for an optional user overide on
EEPROM, 3826.eeprom. The custom EEPROM is optional but if not
present we'll introduce an extra lag of 60 seconds with udev
present. Annotate we don't want udev nonsense here to avoid
the lag in case its not present.
This was found with the following SmPL patch.
@ firmware_not_critical @
expression cf;
expression config_file;
expression dev;
int ret;
identifier l;
statement S;
@@
- ret = request_firmware(&cf, config_file, dev);
+ ret = request_firmware_direct(&cf, config_file, dev);
if (ret < 0) {
... when != goto l;
when != return ret;
when any
} else {
...
release_firmware(cf);
...
}
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Cc: cocci@systeme.lip6.fr
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
Acked-By: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
|
||
|---|---|---|
| .. | ||
| eeprom.c | ||
| eeprom.h | ||
| fwio.c | ||
| Kconfig | ||
| led.c | ||
| lmac.h | ||
| main.c | ||
| Makefile | ||
| net2280.h | ||
| p54.h | ||
| p54pci.c | ||
| p54pci.h | ||
| p54spi.c | ||
| p54spi.h | ||
| p54spi_eeprom.h | ||
| p54usb.c | ||
| p54usb.h | ||
| txrx.c | ||