mirror of
https://github.com/torvalds/linux
synced 2024-07-21 10:41:44 +00:00
![]() The ->destname member of struct ovl_copy_up_ctx is initialized inside ovl_copy_up_one() to ->d_name of the overlayfs dentry being copied up and then it may be overridden by index name inside ovl_do_copy_up(). ovl_inode_lock() in ovl_copy_up_start() and ovl_copy_up() in ovl_rename() effectively stabilze ->d_name of the overlayfs dentry being copied up, but ovl_inode_lock() is not held when ->d_name is being read. It is not a correctness bug, because if ovl_do_copy_up() races with ovl_rename() and ctx.destname is freed, we will not end up calling ovl_do_copy_up() with the dead name reference. The code becomes much easier to understand and to document if the initialization of c->destname is always done inside ovl_do_copy_up(), either to the index entry name, or to the overlay dentry ->d_name. Signed-off-by: Amir Goldstein <amir73il@gmail.com> |
||
---|---|---|
.. | ||
copy_up.c | ||
dir.c | ||
export.c | ||
file.c | ||
inode.c | ||
Kconfig | ||
Makefile | ||
namei.c | ||
overlayfs.h | ||
ovl_entry.h | ||
params.c | ||
params.h | ||
readdir.c | ||
super.c | ||
util.c | ||
xattrs.c |