mirror of
https://github.com/torvalds/linux
synced 2024-09-27 23:10:58 +00:00
26b3c01f7d
RTC core won't allow wakeup alarms to be set if RTC devices' parent (i.e. i2c_client or spi_device) isn't wakeup capable. For I2C devices there is I2C_CLIENT_WAKE flag exists that we can pass via board info, and if set, I2C core will initialize wakeup capability. For SPI devices there is no such flag at all. I believe that it's not platform code responsibility to allow or disallow wakeups, instead, drivers themselves should set the capability if a device can trigger wakeups. That's what drivers/base/power/sysfs.c says: * It is the responsibility of device drivers to enable (or disable) * wakeup signaling as part of changing device power states, respecting * the policy choices provided through the driver model. I2C and SPI RTC devices send wakeup events via interrupt lines, so we should set the wakeup capability if IRQ is routed. Ideally we should also check irq for wakeup capability before setting device's capability, i.e. if (can_irq_wake(irq)) device_set_wakeup_capable(&client->dev, 1); But there is no can_irq_wake() call exist, and it is not that trivial to implement it for all interrupts controllers and complex/cascaded setups. drivers/base/power/sysfs.c also covers these cases: * Devices may not be able to generate wakeup events from all power * states. Also, the events may be ignored in some configurations; * for example, they might need help from other devices that aren't * active So there is no guarantee that wakeup will actually work, and so I think there is no point in being pedantic wrt checking IRQ wakeup capability. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Ben Dooks <ben-linux@fluff.org> Cc: Jean Delvare <khali@linux-fr.org> Cc: Alessandro Zummo <a.zummo@towertech.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| class.c | ||
| hctosys.c | ||
| interface.c | ||
| Kconfig | ||
| Makefile | ||
| rtc-ab3100.c | ||
| rtc-at32ap700x.c | ||
| rtc-at91rm9200.c | ||
| rtc-at91sam9.c | ||
| rtc-au1xxx.c | ||
| rtc-bfin.c | ||
| rtc-bq32k.c | ||
| rtc-bq4802.c | ||
| rtc-cmos.c | ||
| rtc-coh901331.c | ||
| rtc-core.h | ||
| rtc-dev.c | ||
| rtc-dm355evm.c | ||
| rtc-ds1216.c | ||
| rtc-ds1286.c | ||
| rtc-ds1302.c | ||
| rtc-ds1305.c | ||
| rtc-ds1307.c | ||
| rtc-ds1374.c | ||
| rtc-ds1390.c | ||
| rtc-ds1511.c | ||
| rtc-ds1553.c | ||
| rtc-ds1672.c | ||
| rtc-ds1742.c | ||
| rtc-ds3234.c | ||
| rtc-efi.c | ||
| rtc-ep93xx.c | ||
| rtc-fm3130.c | ||
| rtc-generic.c | ||
| rtc-isl1208.c | ||
| rtc-lib.c | ||
| rtc-m41t80.c | ||
| rtc-m41t94.c | ||
| rtc-m48t35.c | ||
| rtc-m48t59.c | ||
| rtc-m48t86.c | ||
| rtc-max6900.c | ||
| rtc-max6902.c | ||
| rtc-mc13783.c | ||
| rtc-msm6242.c | ||
| rtc-mv.c | ||
| rtc-mxc.c | ||
| rtc-nuc900.c | ||
| rtc-omap.c | ||
| rtc-pcap.c | ||
| rtc-pcf2123.c | ||
| rtc-pcf8563.c | ||
| rtc-pcf8583.c | ||
| rtc-pcf50633.c | ||
| rtc-pl030.c | ||
| rtc-pl031.c | ||
| rtc-proc.c | ||
| rtc-ps3.c | ||
| rtc-pxa.c | ||
| rtc-r9701.c | ||
| rtc-rp5c01.c | ||
| rtc-rs5c313.c | ||
| rtc-rs5c348.c | ||
| rtc-rs5c372.c | ||
| rtc-rx8025.c | ||
| rtc-rx8581.c | ||
| rtc-s3c.c | ||
| rtc-s35390a.c | ||
| rtc-sa1100.c | ||
| rtc-sh.c | ||
| rtc-starfire.c | ||
| rtc-stk17ta8.c | ||
| rtc-stmp3xxx.c | ||
| rtc-sun4v.c | ||
| rtc-sysfs.c | ||
| rtc-test.c | ||
| rtc-twl.c | ||
| rtc-tx4939.c | ||
| rtc-v3020.c | ||
| rtc-vr41xx.c | ||
| rtc-wm831x.c | ||
| rtc-wm8350.c | ||
| rtc-x1205.c | ||