mirror of
https://github.com/torvalds/linux
synced 2024-10-19 09:49:29 +00:00
e8444560b4
The HDAudio ASoC support relies on the set_tdm_slots() helper to store the HDaudio stream tag in the tx_mask. This only works because of the pre-existing order in soc-pcm.c, where the hw_params() is handled for codec_dais *before* cpu_dais. When the order is reversed, the stream_tag is used as a mask in the codec fixup functions: /* fixup params based on TDM slot masks */ if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK && codec_dai->tx_mask) soc_pcm_codec_params_fixup(&codec_params, codec_dai->tx_mask); As a result of this confusion, the codec_params_fixup() ends-up generating bad channel masks, depending on what stream_tag was allocated. We could add a flag to state that the tx_mask is really not a mask, but it would be quite ugly to persist in overloading concepts. Instead, this patch suggests a more generic get/set 'stream' API based on the existing model for SoundWire. We can expand the concept to store 'stream' opaque information that is specific to different DAI types. In the case of HDAudio DAIs, we only need to store a stream tag as an unsigned char pointer. The TDM rx_ and tx_masks should really only be used to store masks. Rename get_sdw_stream/set_sdw_stream callbacks and helpers as get_stream/set_stream. No functionality change beyond the rename. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Acked-By: Vinod Koul <vkoul@kernel.org> Link: https://lore.kernel.org/r/20211224021034.26635-5-yung-chuan.liao@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> |
||
|---|---|---|
| .. | ||
| qdsp6 | ||
| apq8016_sbc.c | ||
| apq8096.c | ||
| common.c | ||
| common.h | ||
| Kconfig | ||
| lpass-apq8016.c | ||
| lpass-cpu.c | ||
| lpass-hdmi.c | ||
| lpass-hdmi.h | ||
| lpass-ipq806x.c | ||
| lpass-lpaif-reg.h | ||
| lpass-platform.c | ||
| lpass-sc7180.c | ||
| lpass.h | ||
| Makefile | ||
| sc7180.c | ||
| sdm845.c | ||
| sm8250.c | ||
| storm.c | ||