mirror of
https://github.com/torvalds/linux
synced 2024-09-06 09:51:23 +00:00
![Sven Eckelmann](/assets/img/avatar_default.png)
The header files could not be build indepdent from each other. This is happened because headers didn't include the files for things they've used. This was problematic because the success of a build depended on the knowledge about the right order of local includes. Also source files were not including everything they've used explicitly. Instead they required that transitive includes are always stable. This is problematic because some transitive includes are not obvious, depend on config settings and may not be stable in the future. The order for include blocks are: * primary headers (main.h and the *.h file of a *.c file) * global linux headers * required local headers * extra forward declarations for pointers in function/struct declarations The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h. This header file is shared with userspace applications like batctl and must therefore build together with userspace applications. The header linux/bitops.h is not part of the uapi headers and linux/if_ether.h conflicts with the musl implementation of netinet/if_ether.h. The maintainers rejected the use of __KERNEL__ preprocessor checks and thus these two headers are only in main.h. All files using packet.h first have to include main.h to work correctly. Reported-by: Markus Pargmann <mpa@pengutronix.de> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
58 lines
1.8 KiB
C
58 lines
1.8 KiB
C
/* Copyright (C) 2006-2015 B.A.T.M.A.N. contributors:
|
|
*
|
|
* Simon Wunderlich, Marek Lindner
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of version 2 of the GNU General Public
|
|
* License as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef _NET_BATMAN_ADV_BITARRAY_H_
|
|
#define _NET_BATMAN_ADV_BITARRAY_H_
|
|
|
|
#include "main.h"
|
|
|
|
#include <linux/bitops.h>
|
|
#include <linux/compiler.h>
|
|
#include <linux/types.h>
|
|
|
|
/* Returns 1 if the corresponding bit in the given seq_bits indicates true
|
|
* and curr_seqno is within range of last_seqno. Otherwise returns 0.
|
|
*/
|
|
static inline int batadv_test_bit(const unsigned long *seq_bits,
|
|
uint32_t last_seqno, uint32_t curr_seqno)
|
|
{
|
|
int32_t diff;
|
|
|
|
diff = last_seqno - curr_seqno;
|
|
if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE)
|
|
return 0;
|
|
return test_bit(diff, seq_bits) != 0;
|
|
}
|
|
|
|
/* turn corresponding bit on, so we can remember that we got the packet */
|
|
static inline void batadv_set_bit(unsigned long *seq_bits, int32_t n)
|
|
{
|
|
/* if too old, just drop it */
|
|
if (n < 0 || n >= BATADV_TQ_LOCAL_WINDOW_SIZE)
|
|
return;
|
|
|
|
set_bit(n, seq_bits); /* turn the position on */
|
|
}
|
|
|
|
/* receive and process one packet, returns 1 if received seq_num is considered
|
|
* new, 0 if old
|
|
*/
|
|
int batadv_bit_get_packet(void *priv, unsigned long *seq_bits,
|
|
int32_t seq_num_diff, int set_mark);
|
|
|
|
#endif /* _NET_BATMAN_ADV_BITARRAY_H_ */
|