mirror of
https://github.com/torvalds/linux
synced 2024-07-24 03:59:21 +00:00
e298d8a38b
led_blink_set[_oneshot]()'s delay_on and delay_off function parameters are pass by reference, so that hw-blink implementations can report back the actual achieved delays when the values have been rounded to something the hw supports. This is really only interesting for the sysfs API / the timer trigger. Other triggers don't really care about this and none of the callers of led_trigger_blink[_oneshot]() do anything with the returned delay values. Change the led_trigger_blink[_oneshot]() delay parameters to pass-by-value, there are 2 reasons for this: 1. led_cdev->blink_set() may sleep, while led_trigger_blink() may not. So on hw where led_cdev->blink_set() sleeps the call needs to be deferred to a workqueue, in which case the actual achieved delays are unknown (this is a preparation patch for the deferring). 2. Since the callers don't care about the actual achieved delays, allowing callers to directly pass a value leads to simpler code for most callers. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Tested-by: Yauhen Kharuzhy <jekhor@gmail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> Acked-by: Florian Westphal <fw@strlen.de> Link: https://lore.kernel.org/r/20230510162234.291439-2-hdegoede@redhat.com Signed-off-by: Lee Jones <lee@kernel.org>
87 lines
2.3 KiB
C
87 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright 2006, Johannes Berg <johannes@sipsolutions.net>
|
|
*/
|
|
|
|
#include <linux/list.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/leds.h>
|
|
#include "ieee80211_i.h"
|
|
|
|
#define MAC80211_BLINK_DELAY 50 /* ms */
|
|
|
|
static inline void ieee80211_led_rx(struct ieee80211_local *local)
|
|
{
|
|
#ifdef CONFIG_MAC80211_LEDS
|
|
if (!atomic_read(&local->rx_led_active))
|
|
return;
|
|
led_trigger_blink_oneshot(&local->rx_led, MAC80211_BLINK_DELAY, MAC80211_BLINK_DELAY, 0);
|
|
#endif
|
|
}
|
|
|
|
static inline void ieee80211_led_tx(struct ieee80211_local *local)
|
|
{
|
|
#ifdef CONFIG_MAC80211_LEDS
|
|
if (!atomic_read(&local->tx_led_active))
|
|
return;
|
|
led_trigger_blink_oneshot(&local->tx_led, MAC80211_BLINK_DELAY, MAC80211_BLINK_DELAY, 0);
|
|
#endif
|
|
}
|
|
|
|
#ifdef CONFIG_MAC80211_LEDS
|
|
void ieee80211_led_assoc(struct ieee80211_local *local,
|
|
bool associated);
|
|
void ieee80211_led_radio(struct ieee80211_local *local,
|
|
bool enabled);
|
|
void ieee80211_alloc_led_names(struct ieee80211_local *local);
|
|
void ieee80211_free_led_names(struct ieee80211_local *local);
|
|
void ieee80211_led_init(struct ieee80211_local *local);
|
|
void ieee80211_led_exit(struct ieee80211_local *local);
|
|
void ieee80211_mod_tpt_led_trig(struct ieee80211_local *local,
|
|
unsigned int types_on, unsigned int types_off);
|
|
#else
|
|
static inline void ieee80211_led_assoc(struct ieee80211_local *local,
|
|
bool associated)
|
|
{
|
|
}
|
|
static inline void ieee80211_led_radio(struct ieee80211_local *local,
|
|
bool enabled)
|
|
{
|
|
}
|
|
static inline void ieee80211_alloc_led_names(struct ieee80211_local *local)
|
|
{
|
|
}
|
|
static inline void ieee80211_free_led_names(struct ieee80211_local *local)
|
|
{
|
|
}
|
|
static inline void ieee80211_led_init(struct ieee80211_local *local)
|
|
{
|
|
}
|
|
static inline void ieee80211_led_exit(struct ieee80211_local *local)
|
|
{
|
|
}
|
|
static inline void ieee80211_mod_tpt_led_trig(struct ieee80211_local *local,
|
|
unsigned int types_on,
|
|
unsigned int types_off)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
static inline void
|
|
ieee80211_tpt_led_trig_tx(struct ieee80211_local *local, int bytes)
|
|
{
|
|
#ifdef CONFIG_MAC80211_LEDS
|
|
if (atomic_read(&local->tpt_led_active))
|
|
local->tpt_led_trigger->tx_bytes += bytes;
|
|
#endif
|
|
}
|
|
|
|
static inline void
|
|
ieee80211_tpt_led_trig_rx(struct ieee80211_local *local, int bytes)
|
|
{
|
|
#ifdef CONFIG_MAC80211_LEDS
|
|
if (atomic_read(&local->tpt_led_active))
|
|
local->tpt_led_trigger->rx_bytes += bytes;
|
|
#endif
|
|
}
|