linux/drivers/message/fusion
Gustavo A. R. Silva fd6282af8e scsi: message: fusion: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare variable-length
types such as these ones is a flexible array member[1][2], introduced in
C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by this
change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Link: https://lore.kernel.org/r/20200319222533.GA20577@embeddedor.com
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-03-26 22:40:47 -04:00
..
lsi scsi: message: fusion: fix a few trivial spelling mistakes 2018-09-11 21:18:06 -04:00
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mptbase.c scsi: message: fusion: Use kmemdup instead of memcpy and kmalloc 2019-06-18 19:46:24 -04:00
mptbase.h fusion: remove dead MTRR code 2015-06-13 08:44:14 -07:00
mptctl.c scsi: mptfusion: Fix double fetch bug in ioctl 2020-01-15 23:05:52 -05:00
mptctl.h
mptdebug.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mptfc.c scsi: flip the default on use_clustering 2018-12-18 23:13:12 -05:00
mptlan.c netdev: pass the stuck queue to the timeout handler 2019-12-12 21:38:57 -08:00
mptlan.h scsi: fusion: fix if-statement empty body warning 2020-03-11 23:07:57 -04:00
mptsas.c scsi: mptfusion: fix indentation issues 2019-03-19 17:17:08 -04:00
mptsas.h scsi: message: fusion: Replace zero-length array with flexible-array member 2020-03-26 22:40:47 -04:00
mptscsih.c scsi: mptscsih: Mark expected switch fall-throughs 2019-04-03 23:45:59 -04:00
mptscsih.h scsi: drop reason argument from ->change_queue_depth 2014-11-24 14:45:27 +01:00
mptspi.c scsi: mptfusion: remove set, but not used, variables 2019-03-19 17:19:36 -04:00