mirror of
https://github.com/torvalds/linux
synced 2024-10-20 18:28:21 +00:00
da3a9d3c15
If CONFIG_ATH11K_DEBUGFS is disabled there are warnings debug.c:
drivers/net/wireless/ath/ath11k/debug.c:36:20: warning: 'htt_bp_lmac_ring' defined but not used [-Wunused-variable]
36 | static const char *htt_bp_lmac_ring[HTT_SW_LMAC_RING_IDX_MAX] = {
| ^~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath11k/debug.c:15:20: warning: 'htt_bp_umac_ring' defined but not used [-Wunused-variable]
15 | static const char *htt_bp_umac_ring[HTT_SW_UMAC_RING_IDX_MAX] = {
| ^~~~~~~~~~~~~~~~
Fix this by refactoring debugfs code to debugfs.c. This also reduces the number
of ifdefs in debug.c and makes it easier to maintain the code.
No functional changes. Compile tested only.
Reported-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1600264523-12939-1-git-send-email-kvalo@codeaurora.org
107 lines
2.1 KiB
C
107 lines
2.1 KiB
C
// SPDX-License-Identifier: BSD-3-Clause-Clear
|
|
/*
|
|
* Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/vmalloc.h>
|
|
#include "core.h"
|
|
#include "debug.h"
|
|
|
|
void ath11k_info(struct ath11k_base *ab, const char *fmt, ...)
|
|
{
|
|
struct va_format vaf = {
|
|
.fmt = fmt,
|
|
};
|
|
va_list args;
|
|
|
|
va_start(args, fmt);
|
|
vaf.va = &args;
|
|
dev_info(ab->dev, "%pV", &vaf);
|
|
/* TODO: Trace the log */
|
|
va_end(args);
|
|
}
|
|
EXPORT_SYMBOL(ath11k_info);
|
|
|
|
void ath11k_err(struct ath11k_base *ab, const char *fmt, ...)
|
|
{
|
|
struct va_format vaf = {
|
|
.fmt = fmt,
|
|
};
|
|
va_list args;
|
|
|
|
va_start(args, fmt);
|
|
vaf.va = &args;
|
|
dev_err(ab->dev, "%pV", &vaf);
|
|
/* TODO: Trace the log */
|
|
va_end(args);
|
|
}
|
|
EXPORT_SYMBOL(ath11k_err);
|
|
|
|
void ath11k_warn(struct ath11k_base *ab, const char *fmt, ...)
|
|
{
|
|
struct va_format vaf = {
|
|
.fmt = fmt,
|
|
};
|
|
va_list args;
|
|
|
|
va_start(args, fmt);
|
|
vaf.va = &args;
|
|
dev_warn_ratelimited(ab->dev, "%pV", &vaf);
|
|
/* TODO: Trace the log */
|
|
va_end(args);
|
|
}
|
|
EXPORT_SYMBOL(ath11k_warn);
|
|
|
|
#ifdef CONFIG_ATH11K_DEBUG
|
|
|
|
void __ath11k_dbg(struct ath11k_base *ab, enum ath11k_debug_mask mask,
|
|
const char *fmt, ...)
|
|
{
|
|
struct va_format vaf;
|
|
va_list args;
|
|
|
|
va_start(args, fmt);
|
|
|
|
vaf.fmt = fmt;
|
|
vaf.va = &args;
|
|
|
|
if (ath11k_debug_mask & mask)
|
|
dev_printk(KERN_DEBUG, ab->dev, "%pV", &vaf);
|
|
|
|
/* TODO: trace log */
|
|
|
|
va_end(args);
|
|
}
|
|
EXPORT_SYMBOL(__ath11k_dbg);
|
|
|
|
void ath11k_dbg_dump(struct ath11k_base *ab,
|
|
enum ath11k_debug_mask mask,
|
|
const char *msg, const char *prefix,
|
|
const void *buf, size_t len)
|
|
{
|
|
char linebuf[256];
|
|
size_t linebuflen;
|
|
const void *ptr;
|
|
|
|
if (ath11k_debug_mask & mask) {
|
|
if (msg)
|
|
__ath11k_dbg(ab, mask, "%s\n", msg);
|
|
|
|
for (ptr = buf; (ptr - buf) < len; ptr += 16) {
|
|
linebuflen = 0;
|
|
linebuflen += scnprintf(linebuf + linebuflen,
|
|
sizeof(linebuf) - linebuflen,
|
|
"%s%08x: ",
|
|
(prefix ? prefix : ""),
|
|
(unsigned int)(ptr - buf));
|
|
hex_dump_to_buffer(ptr, len - (ptr - buf), 16, 1,
|
|
linebuf + linebuflen,
|
|
sizeof(linebuf) - linebuflen, true);
|
|
dev_printk(KERN_DEBUG, ab->dev, "%s\n", linebuf);
|
|
}
|
|
}
|
|
}
|
|
EXPORT_SYMBOL(ath11k_dbg_dump);
|
|
|
|
#endif /* CONFIG_ATH11K_DEBUG */
|