mirror of
https://github.com/torvalds/linux
synced 2024-09-29 07:50:45 +00:00
1927661b17
When building modules with CONFIG_SND_IMX_SOC=m in imx_v6_v7_defconfig, we will see the following link error. LD [M] sound/soc/fsl/snd-soc-fsl-ssi.o LD [M] sound/soc/fsl/snd-soc-fsl-utils.o LD [M] sound/soc/fsl/snd-soc-imx-ssi.o LD [M] sound/soc/fsl/snd-soc-imx-audmux.o LD [M] sound/soc/fsl/snd-soc-imx-pcm.o sound/soc/fsl/imx-pcm-dma.o: In function `init_module': imx-pcm-dma.c:(.init.text+0x0): multiple definition of `init_module' sound/soc/fsl/imx-pcm-fiq.o:imx-pcm-fiq.c:(.init.text+0x0): first defined here sound/soc/fsl/imx-pcm-dma.o: In function `cleanup_module': imx-pcm-dma.c:(.exit.text+0x0): multiple definition of `cleanup_module' sound/soc/fsl/imx-pcm-fiq.o:imx-pcm-fiq.c:(.exit.text+0x0): first defined here make[4]: *** [sound/soc/fsl/snd-soc-imx-pcm.o] Error 1 The module snd-soc-imx-pcm is designed to link imx-pcm.o with imx-pcm-dma.o or imx-pcm-fiq.o depending on if option SND_SOC_IMX_PCM_DMA or SND_SOC_IMX_PCM_FIQ is enabled. Both imx-pcm-dma and imx-pcm-fiq register their own module_platform_driver. However, these two options are not mutually exclusive and can be enabled together. And that's why we see above multiple init_module definition error. Instead of having both imx-pcm-dma and imx-pcm-fiq register their own platform_driver, we should do only once in imx-pcm.c. Using platform_device_id to distinguish between imx-pcm-dma and imx-pcm-fiq, we can run-time call imx-pcm-dma/fiq specific initialization in .probe hook to have module snd-soc-imx-pcm work for both cases. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
52 lines
1.3 KiB
C
52 lines
1.3 KiB
C
/*
|
|
* Copyright 2009 Sascha Hauer <s.hauer@pengutronix.de>
|
|
*
|
|
* This code is based on code copyrighted by Freescale,
|
|
* Liam Girdwood, Javier Martin and probably others.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*/
|
|
|
|
#ifndef _IMX_PCM_H
|
|
#define _IMX_PCM_H
|
|
|
|
/*
|
|
* Do not change this as the FIQ handler depends on this size
|
|
*/
|
|
#define IMX_SSI_DMABUF_SIZE (64 * 1024)
|
|
|
|
struct imx_pcm_dma_params {
|
|
int dma;
|
|
unsigned long dma_addr;
|
|
int burstsize;
|
|
bool shared_peripheral; /* The peripheral is on SPBA bus */
|
|
};
|
|
|
|
int snd_imx_pcm_mmap(struct snd_pcm_substream *substream,
|
|
struct vm_area_struct *vma);
|
|
int imx_pcm_new(struct snd_soc_pcm_runtime *rtd);
|
|
void imx_pcm_free(struct snd_pcm *pcm);
|
|
|
|
#ifdef CONFIG_SND_SOC_IMX_PCM_DMA
|
|
int imx_pcm_dma_init(struct platform_device *pdev);
|
|
#else
|
|
static inline int imx_pcm_dma_init(struct platform_device *pdev)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
|
|
#ifdef CONFIG_SND_SOC_IMX_PCM_FIQ
|
|
int imx_pcm_fiq_init(struct platform_device *pdev);
|
|
#else
|
|
static inline int imx_pcm_fiq_init(struct platform_device *pdev)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
|
|
#endif /* _IMX_PCM_H */
|