mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
![Uwe Kleine-König](/assets/img/avatar_default.png)
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Link: https://lore.kernel.org/r/20231109202830.4124591-7-u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
47 lines
1.1 KiB
C
47 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Allwinner A64 Display Engine 2.0 Bus Driver
|
|
*
|
|
* Copyright (C) 2018 Icenowy Zheng <icenowy@aosc.io>
|
|
*/
|
|
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/soc/sunxi/sunxi_sram.h>
|
|
|
|
static int sun50i_de2_bus_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node;
|
|
int ret;
|
|
|
|
ret = sunxi_sram_claim(&pdev->dev);
|
|
if (ret)
|
|
return dev_err_probe(&pdev->dev, ret,
|
|
"Couldn't map SRAM to device\n");
|
|
|
|
of_platform_populate(np, NULL, NULL, &pdev->dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void sun50i_de2_bus_remove(struct platform_device *pdev)
|
|
{
|
|
sunxi_sram_release(&pdev->dev);
|
|
}
|
|
|
|
static const struct of_device_id sun50i_de2_bus_of_match[] = {
|
|
{ .compatible = "allwinner,sun50i-a64-de2", },
|
|
{ /* sentinel */ }
|
|
};
|
|
|
|
static struct platform_driver sun50i_de2_bus_driver = {
|
|
.probe = sun50i_de2_bus_probe,
|
|
.remove_new = sun50i_de2_bus_remove,
|
|
.driver = {
|
|
.name = "sun50i-de2-bus",
|
|
.of_match_table = sun50i_de2_bus_of_match,
|
|
},
|
|
};
|
|
|
|
builtin_platform_driver(sun50i_de2_bus_driver);
|