mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
66bc1a1733
Deduplicate ->read() callbacks of bin_attributes which are backed by a simple buffer in memory: Use the newly introduced sysfs_bin_attr_simple_read() helper instead, either by referencing it directly or by declaring such bin_attributes with BIN_ATTR_SIMPLE_RO() or BIN_ATTR_SIMPLE_ADMIN_RO(). Aside from a reduction of LoC, this shaves off a few bytes from vmlinux (304 bytes on an x86_64 allyesconfig). No functional change intended. Signed-off-by: Lukas Wunner <lukas@wunner.de> Acked-by: Zhi Wang <zhiwang@kernel.org> Acked-by: Michael Ellerman <mpe@ellerman.id.au> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> Link: https://lore.kernel.org/r/92ee0a0e83a5a3f3474845db6c8575297698933a.1712410202.git.lukas@wunner.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
95 lines
2 KiB
C
95 lines
2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* BGRT boot graphic support
|
|
* Authors: Matthew Garrett, Josh Triplett <josh@joshtriplett.org>
|
|
* Copyright 2012 Red Hat, Inc <mjg@redhat.com>
|
|
* Copyright 2012 Intel Corporation
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/device.h>
|
|
#include <linux/sysfs.h>
|
|
#include <linux/efi-bgrt.h>
|
|
|
|
static void *bgrt_image;
|
|
static struct kobject *bgrt_kobj;
|
|
|
|
#define BGRT_SHOW(_name, _member) \
|
|
static ssize_t _name##_show(struct kobject *kobj, \
|
|
struct kobj_attribute *attr, char *buf) \
|
|
{ \
|
|
return sysfs_emit(buf, "%d\n", bgrt_tab._member); \
|
|
} \
|
|
static struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name)
|
|
|
|
BGRT_SHOW(version, version);
|
|
BGRT_SHOW(status, status);
|
|
BGRT_SHOW(type, image_type);
|
|
BGRT_SHOW(xoffset, image_offset_x);
|
|
BGRT_SHOW(yoffset, image_offset_y);
|
|
|
|
static BIN_ATTR_SIMPLE_RO(image);
|
|
|
|
static struct attribute *bgrt_attributes[] = {
|
|
&bgrt_attr_version.attr,
|
|
&bgrt_attr_status.attr,
|
|
&bgrt_attr_type.attr,
|
|
&bgrt_attr_xoffset.attr,
|
|
&bgrt_attr_yoffset.attr,
|
|
NULL,
|
|
};
|
|
|
|
static struct bin_attribute *bgrt_bin_attributes[] = {
|
|
&bin_attr_image,
|
|
NULL,
|
|
};
|
|
|
|
static const struct attribute_group bgrt_attribute_group = {
|
|
.attrs = bgrt_attributes,
|
|
.bin_attrs = bgrt_bin_attributes,
|
|
};
|
|
|
|
int __init acpi_parse_bgrt(struct acpi_table_header *table)
|
|
{
|
|
efi_bgrt_init(table);
|
|
return 0;
|
|
}
|
|
|
|
static int __init bgrt_init(void)
|
|
{
|
|
int ret;
|
|
|
|
if (!bgrt_tab.image_address)
|
|
return -ENODEV;
|
|
|
|
bgrt_image = memremap(bgrt_tab.image_address, bgrt_image_size,
|
|
MEMREMAP_WB);
|
|
if (!bgrt_image) {
|
|
pr_notice("Ignoring BGRT: failed to map image memory\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
bin_attr_image.private = bgrt_image;
|
|
bin_attr_image.size = bgrt_image_size;
|
|
|
|
bgrt_kobj = kobject_create_and_add("bgrt", acpi_kobj);
|
|
if (!bgrt_kobj) {
|
|
ret = -EINVAL;
|
|
goto out_memmap;
|
|
}
|
|
|
|
ret = sysfs_create_group(bgrt_kobj, &bgrt_attribute_group);
|
|
if (ret)
|
|
goto out_kobject;
|
|
|
|
return 0;
|
|
|
|
out_kobject:
|
|
kobject_put(bgrt_kobj);
|
|
out_memmap:
|
|
memunmap(bgrt_image);
|
|
return ret;
|
|
}
|
|
device_initcall(bgrt_init);
|