linux/drivers/parport
Andy Shevchenko 12280cc708 parport: Clean up resources correctly when parport_register_port() fails
The smatch warns about uncleaned resources in case the
parport_register_port() fails:

  parport_register_port() warn: '&tmp->full_list' not removed from list

This is indeed an issue introduced when converting code to use
kasprintf(). However, the whole kasprintf() dance in this case
is not needed as dev_set_name() can handle the formatted input
and produces the same result. So, the solution is to delegate
name forming to the dev_set_name() and make device_register()
error path to deal with error handling (via put_device() call).

Fixes: 8d8ae17eb0 ("parport: Use kasprintf() instead of fixed buffer formatting")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202310180809.hepZB9k6-lkp@intel.com/
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231018145948.1367648-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-10-21 23:04:23 +02:00
..
BUGS-parport
daisy.c
ieee1284.c
ieee1284_ops.c
Kconfig
Makefile
multiface.h
parport_amiga.c
parport_atari.c
parport_cs.c
parport_gsc.c
parport_gsc.h
parport_ip32.c
parport_mfc3.c
parport_pc.c
parport_serial.c
parport_sunbpp.c
probe.c
procfs.c
share.c parport: Clean up resources correctly when parport_register_port() fails 2023-10-21 23:04:23 +02:00
TODO-parport