mirror of
https://github.com/torvalds/linux
synced 2024-09-22 12:26:27 +00:00
102eb97564
Currently, 'modalias' in the spi_device structure is a 'const char *'. The spi_new_device() function fills in the modalias value from a passed in spi_board_info data block. Since it is a pointer copy, the new spi_device remains dependent on the spi_board_info structure after the new spi_device is registered (no other fields in spi_device directly depend on the spi_board_info structure; all of the other data is copied). This causes a problem when dynamically propulating the list of attached SPI devices. For example, in arch/powerpc, the list of SPI devices can be populated from data in the device tree. With the current code, the device tree adapter must kmalloc() a new spi_board_info structure for each new SPI device it finds in the device tree, and there is no simple mechanism in place for keeping track of these allocations. This patch changes modalias from a 'const char *' to a fixed char array. By copying the modalias string instead of referencing it, the dependency on the spi_board_info structure is eliminated and an outside caller does not need to maintain a separate spi_board_info allocation for each device. If searched through the code to the best of my ability for any references to modalias which may be affected by this change and haven't found anything. It has been tested with the lite5200b platform in arch/powerpc. [dbrownell@users.sourceforge.net: cope with linux-next changes: KOBJ_NAME_LEN obliterated, etc] Signed-off-by: Grant Likely <grant.likely@secretlab.ca> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| at25.c | ||
| atmel_spi.c | ||
| atmel_spi.h | ||
| au1550_spi.c | ||
| Kconfig | ||
| Makefile | ||
| mpc52xx_psc_spi.c | ||
| omap2_mcspi.c | ||
| omap_uwire.c | ||
| pxa2xx_spi.c | ||
| spi.c | ||
| spi_bfin5xx.c | ||
| spi_bitbang.c | ||
| spi_butterfly.c | ||
| spi_imx.c | ||
| spi_lm70llp.c | ||
| spi_mpc83xx.c | ||
| spi_s3c24xx.c | ||
| spi_s3c24xx_gpio.c | ||
| spi_sh_sci.c | ||
| spi_txx9.c | ||
| spidev.c | ||
| tle62x0.c | ||
| xilinx_spi.c | ||