Eric Dumazet 5361e209dd net: avoid one splat in fib_nl_delrule() ... We need to use refcount_set() on a newly created rule to avoid following error : [ 64.601749] ------------[ cut here ]------------ [ 64.601757] WARNING: CPU: 0 PID: 6476 at lib/refcount.c:184 refcount_sub_and_test+0x75/0xa0 [ 64.601758] Modules linked in: w1_therm wire cdc_acm ehci_pci ehci_hcd mlx4_en ib_uverbs mlx4_ib ib_core mlx4_core [ 64.601769] CPU: 0 PID: 6476 Comm: ip Tainted: G W 4.12.0-smp-DEV #274 [ 64.601771] task: ffff8837bf482040 task.stack: ffff8837bdc08000 [ 64.601773] RIP: 0010:refcount_sub_and_test+0x75/0xa0 [ 64.601774] RSP: 0018:ffff8837bdc0f5c0 EFLAGS: 00010286 [ 64.601776] RAX: 0000000000000026 RBX: 0000000000000001 RCX: 0000000000000000 [ 64.601777] RDX: 0000000000000026 RSI: 0000000000000096 RDI: ffffed06f7b81eae [ 64.601778] RBP: ffff8837bdc0f5d0 R08: 0000000000000004 R09: fffffbfff4a54c25 [ 64.601779] R10: 00000000cbc500e5 R11: ffffffffa52a6128 R12: ffff881febcf6f24 [ 64.601779] R13: ffff881fbf4eaf00 R14: ffff881febcf6f80 R15: ffff8837d7a4ed00 [ 64.601781] FS: 00007ff5a2f6b700(0000) GS:ffff881fff800000(0000) knlGS:0000000000000000 [ 64.601782] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 64.601783] CR2: 00007ffcdc70d000 CR3: 0000001f9c91e000 CR4: 00000000001406f0 [ 64.601783] Call Trace: [ 64.601786] refcount_dec_and_test+0x11/0x20 [ 64.601790] fib_nl_delrule+0xc39/0x1630 [ 64.601793] ? is_bpf_text_address+0xe/0x20 [ 64.601795] ? fib_nl_newrule+0x25e0/0x25e0 [ 64.601798] ? depot_save_stack+0x133/0x470 [ 64.601801] ? ns_capable+0x13/0x20 [ 64.601803] ? __netlink_ns_capable+0xcc/0x100 [ 64.601806] rtnetlink_rcv_msg+0x23a/0x6a0 [ 64.601808] ? rtnl_newlink+0x1630/0x1630 [ 64.601811] ? memset+0x31/0x40 [ 64.601813] netlink_rcv_skb+0x2d7/0x440 [ 64.601815] ? rtnl_newlink+0x1630/0x1630 [ 64.601816] ? netlink_ack+0xaf0/0xaf0 [ 64.601818] ? kasan_unpoison_shadow+0x35/0x50 [ 64.601820] ? __kmalloc_node_track_caller+0x4c/0x70 [ 64.601821] rtnetlink_rcv+0x28/0x30 [ 64.601823] netlink_unicast+0x422/0x610 [ 64.601824] ? netlink_attachskb+0x650/0x650 [ 64.601826] netlink_sendmsg+0x7b7/0xb60 [ 64.601828] ? netlink_unicast+0x610/0x610 [ 64.601830] ? netlink_unicast+0x610/0x610 [ 64.601832] sock_sendmsg+0xba/0xf0 [ 64.601834] ___sys_sendmsg+0x6a9/0x8c0 [ 64.601835] ? copy_msghdr_from_user+0x520/0x520 [ 64.601837] ? __alloc_pages_nodemask+0x160/0x520 [ 64.601839] ? memcg_write_event_control+0xd60/0xd60 [ 64.601841] ? __alloc_pages_slowpath+0x1d50/0x1d50 [ 64.601843] ? kasan_slab_free+0x71/0xc0 [ 64.601845] ? mem_cgroup_commit_charge+0xb2/0x11d0 [ 64.601847] ? lru_cache_add_active_or_unevictable+0x7d/0x1a0 [ 64.601849] ? __handle_mm_fault+0x1af8/0x2810 [ 64.601851] ? may_open_dev+0xc0/0xc0 [ 64.601852] ? __pmd_alloc+0x2c0/0x2c0 [ 64.601853] ? __fdget+0x13/0x20 [ 64.601855] __sys_sendmsg+0xc6/0x150 [ 64.601856] ? __sys_sendmsg+0xc6/0x150 [ 64.601857] ? SyS_shutdown+0x170/0x170 [ 64.601859] ? handle_mm_fault+0x28a/0x650 [ 64.601861] SyS_sendmsg+0x12/0x20 [ 64.601863] entry_SYSCALL_64_fastpath+0x13/0x94 Fixes: 717d1e993a ("net: convert fib_rule.refcnt from atomic_t to refcount_t") Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-07-03 03:29:14 -07:00
..
datagram.c	net: convert sock.sk_wmem_alloc from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
dev.c	net: core: Fix slab-out-of-bounds in netdev_stats_to_stats64	2017-07-03 02:40:23 -07:00
dev_addr_lists.c
dev_ioctl.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-06-21 17:35:22 -04:00
devlink.c	devlink: fix potential memort leak	2017-06-05 11:24:28 -04:00
drop_monitor.c	drop_monitor: use setup_timer	2017-03-12 23:47:16 -07:00
dst.c	net: store port/representator id in metadata_dst	2017-06-25 11:42:01 -04:00
dst_cache.c
ethtool.c	net: Add ESP offload features	2017-04-14 10:05:36 +02:00
fib_rules.c	net: avoid one splat in fib_nl_delrule()	2017-07-03 03:29:14 -07:00
filter.c	bpf: simplify narrower ctx access	2017-07-03 02:22:52 -07:00
flow.c	flowcache: more "unsigned int"	2017-04-03 19:04:48 -07:00
flow_dissector.c	net/flow_dissector: add support for dissection of misc ip header fields	2017-06-04 18:12:23 -04:00
gen_estimator.c
gen_stats.c
gro_cells.c	net: Generic XDP	2017-04-25 13:33:49 -04:00
hwbm.c
link_watch.c
lwt_bpf.c	net: add extack arg to lwtunnel build state	2017-05-30 11:55:32 -04:00
lwtunnel.c	net: add extack arg to lwtunnel build state	2017-05-30 11:55:32 -04:00
Makefile
neighbour.c	net: convert neigh_params.refcnt from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
net-procfs.c	net-procfs: Use vsnprintf extension %phN	2017-06-04 19:52:58 -04:00
net-sysfs.c	net: convert net.passive from atomic_t to refcount_t	2017-07-01 07:39:09 -07:00
net-sysfs.h
net-traces.c
net_namespace.c	net: convert net.passive from atomic_t to refcount_t	2017-07-01 07:39:09 -07:00
netclassid_cgroup.c	cgroup, net_cls: iterate the fds of only the tasks which are being migrated	2017-03-22 10:32:46 -07:00
netevent.c
netpoll.c	net: convert netpoll_info.refcnt from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
netprio_cgroup.c	net: break include loop netdevice.h, dsa.h, devlink.h	2017-03-28 22:46:04 -07:00
pktgen.c	net: convert sk_buff.users from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
ptp_classifier.c
request_sock.c
rtnetlink.c	net: convert sk_buff.users from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
scm.c
secure_seq.c	tcp: Namespaceify sysctl_tcp_timestamps	2017-06-08 10:53:29 -04:00
skbuff.c	net: convert sock.sk_refcnt from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
sock.c	net: convert sock.sk_refcnt from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
sock_diag.c	netlink: extended ACK reporting	2017-04-13 13:58:20 -04:00
sock_reuseport.c	soreuseport: use "unsigned int" in __reuseport_alloc()	2017-04-03 19:06:38 -07:00
stream.c
sysctl_net_core.c	net: move somaxconn init from sysctl code	2017-05-25 13:12:17 -04:00
timestamping.c
tso.c
utils.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-05-02 16:40:27 -07:00