Held Bernhard 0972ddb237 net: provide cow_metrics() methods to blackhole dst_ops ... Since commit 62fa8a846d (net: Implement read-only protection and COW'ing of metrics.) the kernel throws an oops. [ 101.620985] BUG: unable to handle kernel NULL pointer dereference at (null) [ 101.621050] IP: [< (null)>] (null) [ 101.621084] PGD 6e53c067 PUD 3dd6a067 PMD 0 [ 101.621122] Oops: 0010 [#1] SMP [ 101.621153] last sysfs file: /sys/devices/virtual/ppp/ppp/uevent [ 101.621192] CPU 2 [ 101.621206] Modules linked in: l2tp_ppp pppox ppp_generic slhc l2tp_netlink l2tp_core deflate zlib_deflate twofish_x86_64 twofish_common des_generic cbc ecb sha1_generic hmac af_key iptable_filter snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device loop snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_pcm snd_timer snd i2c_i801 iTCO_wdt psmouse soundcore snd_page_alloc evdev uhci_hcd ehci_hcd thermal [ 101.621552] [ 101.621567] Pid: 5129, comm: openl2tpd Not tainted 2.6.39-rc4-Quad #3 Gigabyte Technology Co., Ltd. G33-DS3R/G33-DS3R [ 101.621637] RIP: 0010:[<0000000000000000>] [< (null)>] (null) [ 101.621684] RSP: 0018:ffff88003ddeba60 EFLAGS: 00010202 [ 101.621716] RAX: ffff88003ddb5600 RBX: ffff88003ddb5600 RCX: 0000000000000020 [ 101.621758] RDX: ffffffff81a69a00 RSI: ffffffff81b7ee61 RDI: ffff88003ddb5600 [ 101.621800] RBP: ffff8800537cd900 R08: 0000000000000000 R09: ffff88003ddb5600 [ 101.621840] R10: 0000000000000005 R11: 0000000000014b38 R12: ffff88003ddb5600 [ 101.621881] R13: ffffffff81b7e480 R14: ffffffff81b7e8b8 R15: ffff88003ddebad8 [ 101.621924] FS: 00007f06e4182700(0000) GS:ffff88007fd00000(0000) knlGS:0000000000000000 [ 101.621971] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 101.622005] CR2: 0000000000000000 CR3: 0000000045274000 CR4: 00000000000006e0 [ 101.622046] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 101.622087] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 101.622129] Process openl2tpd (pid: 5129, threadinfo ffff88003ddea000, task ffff88003de9a280) [ 101.622177] Stack: [ 101.622191] ffffffff81447efa ffff88007d3ded80 ffff88003de9a280 ffff88007d3ded80 [ 101.622245] 0000000000000001 ffff88003ddebbb8 ffffffff8148d5a7 0000000000000212 [ 101.622299] ffff88003dcea000 ffff88003dcea188 ffffffff00000001 ffffffff81b7e480 [ 101.622353] Call Trace: [ 101.622374] [<ffffffff81447efa>] ? ipv4_blackhole_route+0x1ba/0x210 [ 101.622415] [<ffffffff8148d5a7>] ? xfrm_lookup+0x417/0x510 [ 101.622450] [<ffffffff8127672a>] ? extract_buf+0x9a/0x140 [ 101.622485] [<ffffffff8144c6a0>] ? __ip_flush_pending_frames+0x70/0x70 [ 101.622526] [<ffffffff8146fbbf>] ? udp_sendmsg+0x62f/0x810 [ 101.622562] [<ffffffff813f98a6>] ? sock_sendmsg+0x116/0x130 [ 101.622599] [<ffffffff8109df58>] ? find_get_page+0x18/0x90 [ 101.622633] [<ffffffff8109fd6a>] ? filemap_fault+0x12a/0x4b0 [ 101.622668] [<ffffffff813fb5c4>] ? move_addr_to_kernel+0x64/0x90 [ 101.622706] [<ffffffff81405d5a>] ? verify_iovec+0x7a/0xf0 [ 101.622739] [<ffffffff813fc772>] ? sys_sendmsg+0x292/0x420 [ 101.622774] [<ffffffff810b994a>] ? handle_pte_fault+0x8a/0x7c0 [ 101.622810] [<ffffffff810b76fe>] ? __pte_alloc+0xae/0x130 [ 101.622844] [<ffffffff810ba2f8>] ? handle_mm_fault+0x138/0x380 [ 101.622880] [<ffffffff81024af9>] ? do_page_fault+0x189/0x410 [ 101.622915] [<ffffffff813fbe03>] ? sys_getsockname+0xf3/0x110 [ 101.622952] [<ffffffff81450c4d>] ? ip_setsockopt+0x4d/0xa0 [ 101.622986] [<ffffffff813f9932>] ? sockfd_lookup_light+0x22/0x90 [ 101.623024] [<ffffffff814b61fb>] ? system_call_fastpath+0x16/0x1b [ 101.623060] Code: Bad RIP value. [ 101.623090] RIP [< (null)>] (null) [ 101.623125] RSP <ffff88003ddeba60> [ 101.623146] CR2: 0000000000000000 [ 101.650871] ---[ end trace ca3856a7d8e8dad4 ]--- [ 101.651011] __sk_free: optmem leakage (160 bytes) detected. The oops happens in dst_metrics_write_ptr() include/net/dst.h:124: return dst->ops->cow_metrics(dst, p); dst->ops->cow_metrics is NULL and causes the oops. Provide cow_metrics() methods, like we did in commit 214f45c91b (net: provide default_advmss() methods to blackhole dst_ops) Signed-off-by: Held Bernhard <berny156@gmx.de> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2011-04-25 11:53:08 -07:00
..
netfilter	Fix common misspellings	2011-03-31 11:26:23 -03:00
addrconf.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
addrconf_core.c	ipv6: Remove IPV6_ADDR_RESERVED	2010-02-26 03:59:07 -08:00
addrlabel.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2010-09-27 01:03:03 -07:00
af_inet6.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
ah6.c	xfrm: Use separate low and high order bits of the sequence numbers in xfrm_skb_cb	2011-03-13 20:22:28 -07:00
anycast.c	net-next: remove useless union keyword	2010-06-10 23:31:35 -07:00
datagram.c	net: Put fl6_* macros to struct flowi6 and use them again.	2011-03-12 15:08:55 -08:00
esp6.c	esp6: Add support for IPsec extended sequence numbers	2011-03-13 20:22:29 -07:00
exthdrs.c	ipv6: Convert to use flowi6 where applicable.	2011-03-12 15:08:54 -08:00
exthdrs_core.c	net: return operator cleanup	2010-09-23 14:33:39 -07:00
fib6_rules.c	ipv6: Convert to use flowi6 where applicable.	2011-03-12 15:08:54 -08:00
icmp.c	net: Put fl6_* macros to struct flowi6 and use them again.	2011-03-12 15:08:55 -08:00
inet6_connection_sock.c	Revert "tcp: disallow bind() to reuse addr/port"	2011-04-13 12:01:14 -07:00
inet6_hashtables.c	Kill off warning: ‘inline’ is not at beginning of declaration	2011-01-19 15:43:08 +01:00
ip6_fib.c	ipv6: Convert to use flowi6 where applicable.	2011-03-12 15:08:54 -08:00
ip6_flowlabel.c	ipv6: Convert to use flowi6 where applicable.	2011-03-12 15:08:54 -08:00
ip6_input.c	Merge branch 'master' of /repos/git/net-next-2.6	2010-04-20 16:02:01 +02:00
ip6_output.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
ip6_tunnel.c	ipv6: Convert to use flowi6 where applicable.	2011-03-12 15:08:54 -08:00
ip6mr.c	net: use CHECKSUM_NONE instead of magic number	2011-03-27 23:35:05 -07:00
ipcomp6.c	xfrm: SA lookups signature with mark	2010-02-22 16:20:22 -08:00
ipv6_sockglue.c	ipv6: Convert to use flowi6 where applicable.	2011-03-12 15:08:54 -08:00
Kconfig	ipv6: ip6mr: support multiple tables	2010-05-11 14:40:55 +02:00
Makefile	[IPV6] MROUTE: Support multicast forwarding.	2008-04-05 22:33:38 +09:00
mcast.c	ipv6: Convert to use flowi6 where applicable.	2011-03-12 15:08:54 -08:00
mip6.c	net: Put fl6_* macros to struct flowi6 and use them again.	2011-03-12 15:08:55 -08:00
ndisc.c	net: gre: provide multicast mappings for ipv4 and ipv6	2011-03-30 00:10:47 -07:00
netfilter.c	netfilter: af_info: add 'strict' parameter to limit lookup to .oif	2011-04-04 17:00:54 +02:00
proc.c	ipv6/udp: report SndbufErrors and RcvbufErrors	2010-10-30 16:17:23 -07:00
protocol.c	net: add __rcu annotations to protocol	2010-10-27 11:37:31 -07:00
raw.c	net: Put fl6_* macros to struct flowi6 and use them again.	2011-03-12 15:08:55 -08:00
reassembly.c	ipv6: Prepare the tree for un-inlined jhash.	2010-11-28 11:26:21 -08:00
route.c	net: provide cow_metrics() methods to blackhole dst_ops	2011-04-25 11:53:08 -07:00
sit.c	ipv4: Create and use route lookup helpers.	2011-03-12 15:08:42 -08:00
syncookies.c	net: Put fl6_* macros to struct flowi6 and use them again.	2011-03-12 15:08:55 -08:00
sysctl_net_ipv6.c	net ipv6: Fix duplicate /proc/sys/net/ipv6/neigh directory entries.	2011-03-21 18:23:34 -07:00
tcp_ipv6.c	ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets (v2)	2011-04-06 13:07:09 -07:00
tunnel6.c	tunnels: add _rcu annotations	2010-10-25 13:09:45 -07:00
udp.c	ipv6: udp: fix the wrong headroom check	2011-04-21 10:39:10 -07:00
udp_impl.h	net: Make setsockopt() optlen be unsigned.	2009-09-30 16:12:20 -07:00
udplite.c	net: fix nulls list corruptions in sk_prot_alloc	2010-12-16 14:26:56 -08:00
xfrm6_input.c	netfilter: ipv6: use NFPROTO values for NF_HOOK invocation	2010-03-25 16:00:49 +01:00
xfrm6_mode_beet.c	ipsec: Interfamily IPSec BEET, ipv4-inner ipv6-outer	2008-08-06 02:40:25 -07:00
xfrm6_mode_ro.c	[IPSEC]: Make x->lastused an unsigned long	2008-01-28 14:53:52 -08:00
xfrm6_mode_transport.c	[IPSEC]: Use IPv6 calling convention as the convention for x->mode->output	2007-10-10 16:55:54 -07:00
xfrm6_mode_tunnel.c	ipv6: Use ip6_dst_hoplimit() instead of direct dst_metric() calls.	2010-12-12 21:14:46 -08:00
xfrm6_output.c	ipv6: Fragment locally generated tunnel-mode IPSec6 packets as needed.	2010-12-19 20:22:23 -08:00
xfrm6_policy.c	net: Put fl6_* macros to struct flowi6 and use them again.	2011-03-12 15:08:55 -08:00
xfrm6_state.c	net: Use flowi4 and flowi6 in xfrm layer.	2011-03-12 15:08:52 -08:00
xfrm6_tunnel.c	xfrm6: make xfrm6_tunnel_free_spi local	2010-10-21 03:09:45 -07:00