Commit graph

190815 commits

Author SHA1 Message Date
Ruslan Pisarev
1fc5af161f Staging: rtl8192u: fix comments and space coding style issue in dot11d.h
This is a patch to the dot11d.h file that fixed up a comments and space
Errors found by the checkpatch.pl tools

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:55 -07:00
Ruslan Pisarev
1695eb36bf Staging: serqt_usb2: fix space coding style issue in serqt_usb2.c
This is a patch to the serqt_usb2.c files that fixed space error and
warning found by the checkpatch.pl tools.

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
John Church
cb73da2524 Staging: rtl8187se: fix coding style issues in r8180_core.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John Church <j.church@ymail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Samuel Ortiz
a5e135b1f5 Staging: rtl8187se: Do not mess with carrier settings while scanning
Toggling the link carrier is a non sense and is the grossest locking I can
think of. Moreover, it's giving a completely inaccurate status to userspace
who could for example decide to turn the interface down on carrier off
detection.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Samuel Ortiz
592010bb71 Staging: rtl8187se: Do not send NULL BSSID events when not associated
If we're not associated, we should not send wireless events to let userspace
know that we just left an ESSID, simply because we havent yet joined it.
If we keep on doing that, wpa_supplicant could receive such events while
actually trying to join an ESSID, and thus decide to stop trying. This leads
to a lot of connection failures as this driver seems to be sending GIWAP
events quite a lot.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Samuel Ortiz
3eec314fb2 Staging: rtl8187se: Do not autoconnect based on probe response
Getting a probe response after sending a probe request to a specific SSID
doesnt mean we're trying to associate with this SSID.
wpa_supplicant should be the only one deciding when to join an SSID, not the
kernel.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Ng Kian Yong
b46966ee8f Staging: vt6655: fix brace coding style issue in ioctl.c
This is a patch to the ioctl.c file that fixes up a brace warning found
by the checkpatch.pl tool

Signed-off-by: Ng Kian Yong <ngky@comp.nus.edu.sg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Pavel Machek
3b7b31fa7d Staging: udlfb: minor cleanups
This cleans up udlfb a tiny bit.

Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Olimpiu Pascariu
593ef41c95 Staging: rtl8187se: fixed checkpatch.pl warnings and errors in r8180_rtl8225z2.c
This is a patch to the r8180_rtl8225z2.c file that fixes up errors and
warnings found by the checkpatch.pl tool

Signed-off-by: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Soeren Moeller
08db6c59a2 Staging: quatech_usb2: fix coding style issues
This is a patch to the file quatech_usb2.c that fixes two space before
tabular and one line of more than 80 characters warnings found by
checkpatch.pl

Signed-off-by: Soeren Moeller <soerenmoeller2001@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Ossama Othman
933025b608 Staging: add initial memrar ABI document
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:54 -07:00
Javier Muñoz Mellid
d82f139b58 Staging: sm7xx: Fixed coding style issue
Fixed a format issue

Signed-off-by: Javier Muñoz Mellid <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Daniel Kenji Toyama
ff8041bb7c Staging: vt6656: int.c: Fixed Coding Style issues
Fixed almost all the issues given by checkpatch.pl except for one
warning about an 81 character line, which cannot really be decomposed
(the code is a bit too nested there).

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Daniel Kenji Toyama
6dde1c6c8e Staging: vt6656: tcrc.c: Fixed coding style issues
Fixed minor problems with indentation.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Daniel Kenji Toyama
b77694be75 Staging: vt6656: tether.c: Fixed coding style issues
Fixed some indentation and spacing issues.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Daniel Kenji Toyama
183cd29562 Staging: vt6656: michael.c: Fixed coding style issues
Replaced lots of spaces by real tabs and resolved other minor issues.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Daniel Kenji Toyama
f9ea02af48 Staging: vt6656: control.c: Fixed coding style issues
Replaced lots of spaces by real tabs and fixed some 80+ lines.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Daniel Kenji Toyama
69d5b4919f Staging: vt6656: rc4.c: Fixed coding style issues
Replaced all indentation by spaces by tabs.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Johan Meiring
c98aaf8555 Staging: line6: rewrote inline comments in control.h
This is a patch to control.h that presents certain inline comments in a
neater way, and which eliminates the 80 character error found by the
checkpatch.pl tool.

Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Bill Pemberton
b1a5fad4c3 Staging: vme: declare vme_calc_slot() as static
vme_calc_slot() is not used anywhere other than vme.c so it should be
declared as static.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:53 -07:00
Bill Pemberton
1fe923ec74 Staging: vme: declare vme_bus_num_mtx static
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Martyn Welch
7946328faf Staging: vme: Correct checkpatch errors
Correct numerous checkpatch errors in the vme driver.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Martyn Welch
48d9356e77 Staging: vme: Use dev_err rather than printk
Replace instances of printk with dev_err where possible.

Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Florian Schilhabel
ebbfda1e65 Staging: rtl8192su: changed check_reset_cnt to be static again
variable check_reset_cnt in rtl819x_watchdog_wqcallback is now static
again.

also, little cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Florian Schilhabel
df35bf66ee Staging: rtl8192su: some work on SetBWModeCallback8192SUsbWorkItem
mostly cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Florian Schilhabel
8e399b0332 Staging: rtl8192su: removed 2 printks in rtl8192SU_link_change
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Florian Schilhabel
f06ebfee17 Staging: rtl8192su: refactored FirmwareDownload92S
added a new function: FirmwareRequest92S

This function(instead of FirmwareDownload92S) is now responsible for
requesting the firmware.

FirmwareDownload92S is now easier to read, smaller and follows kernel
coding style.

plus cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Florian Schilhabel
8dbe821edf Staging: rtl8192su: refactored EnableHWSecurityConfig8192 and setKey
refactored EnableHWSecurityConfig8192 and setKey a bit by replacing
if...else if... else with switch...case

plus cosmetics

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Jonas Lundqvist
33f84a8f21 Staging: phison: fix incorrect tabs in phison.c
This patch fixes two incorrect tab warnings found by the checkpatch.pl
tool

Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:52 -07:00
Ruslan Pisarev
fa51929f66 Staging: wlags49_h2: fix copyright and comments style issue in dhfcfg.h
This is a patch to the dhfcfg.h file that fixed up a copyright and
commets style Errors found by the checkpatch.pl tools

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
1ef61183ce Staging: wlags49_h2: fix space and comments style issue in dhf.h
This is a patch to the dhf.c file that fixed up a space and comments
style Errors found by the checkpatch.pl tools

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
7adea182f1 Staging: wlags49_h2: fix copyright and space style issue in dhf.h
This is a patch to the dhf.h file that fixed up a copyright anf space
style Errors found by the checkpatch.pl tools

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
437de951ec Staging: wlags49_h2: fix trailing statements coding style issue in dhf.c
This is a patch to the dhf.c file that fixed up a trailing statements
Errors found by the checkpatch.pl tools, like
	trailing statements should be on next line

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
068b561c3c Staging: wlags49_h2: fix TAB and space coding style issue dhf.c
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
ccc75a583d Staging: wlags49_h2: fix copyright style issue in dhf.c
This is a patch to the dhf.c file that fixed up a copyright style Errors
found by the checkpatch.pl tools

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
fd547f1fea Staging: wlags49_h2: fix comments coding style issue in dhf.c
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
	do not use C99 // comments

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
01ce33545f Staging: wlags49_h2: fix TAB and space coding style issue in ap_h2.c
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
0a13dfdffc Staging: wlags49_h2: fix comments coding style issue in ap_h2.c
This is a patch to the ap_h2.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
	do not use C99 // comments

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:51 -07:00
Ruslan Pisarev
b93634c4e3 Staging: wlags49_h2: fix spaces, macros and comments coding style issue in debug.h
This is a patch to the debug.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
	spaces required around that '&' (ctx:VxV)
and
	ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
and
	do not use C99 // comments
and
	Macros with complex values should be enclosed in parenthesis

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Richard Kennedy
51b2a02869 Staging: wlan-ng: refactor p80211wext.c to reduce text size.
Refactor the wext interface to reduce lines of code & module text size.

- add a helper function p80211wext_getmib
- rename p80211wext_dorequest to p80211wext_setmib
- refactor wext to call the get/set mib helpers and so reduce repeated code.

size reported text reduction :-
   text	   data	    bss	    dec	    hex	filename
   8343	    720	      0	   9063	   2367	p80211wext.o.patch
   9907	    720	      0	  10631	   2987	p80211wext.o.orig

Tested on x86_32 laptop, everything works correctly using NetworkManager,
and iwconfig & iwlist return sensible results when reading from the card.

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Richard Kennedy
044bc96bef Staging: wlan-ng: fix p80211wext_mhz_to_channel for channel 14
Channel 14 is 2484 Mhz (cf p80211wext_channel_to_mhz) so this patch
corrects what seems to be just a typo.

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Richard Kennedy
9d3b3bb0b5 Staging: wlan-ng: tidy up iw_handler
Use array initialisation technique copied from ipw2200.c.

This should always get the function pointers in the correct place,
without the needed for endless counting, skipping blanks etc.

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Edgardo Hames
4ffab68882 Staging: wlan-ng: rework code style after feedback
This patch includes the feedback received from Richard Kennedy.

Signed-off-by: Edgardo Hames <ehames@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Ruslan Pisarev
5813b6243c Staging: wlan-ng: fix spaces coding style issue in p80211conv.c
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
	spaces required around that '&' (ctx:VxV)

Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Lars Lindley
e5851c205d Staging: winbond: wbusb.c Coding style fixes.
I fixed the reported checkpatch.pl problems except for a bunch of
long lines and some printk:s.
I also removed versioning comments.

Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Lars Lindley
912457fa4f Staging: winbond: wbusb_s.h Coding style fixes.
I fixed comments and some spacing.

Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Lars Lindley
83ad993d65 Staging: winbond: wblinux_f.h Coding style fixes v2.
I fixed whitespace and comments.

Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Lars Lindley
5a7df3c449 Staging: winbond: wbhal_s.h Coding style fixes.
I fixed checkpatch warnings except some long lines and typedefs.
I also removed versioning comments.

Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:50 -07:00
Lars Lindley
b66e65e2fe Staging: winbond: wbhal_f.h Coding style fixes.
I fixed all checkpatch problems and also converted the
function arguments from hungarian notation and CamelCase.

Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Dan Carpenter <error27@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:49 -07:00
Lars Lindley
6112fd6ebb Staging: winbond: wb35rx.c Coding style fixes v2.
New patch that fixes an unclear comment too.

I fixed checkpatch issues except for long lines and printk:s.
I also removed version comments and the () in a return statement.
Generated .o is identical to master and i checked the code with
Dan Carpenters strip_whitespace.pl and diff.

Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Dan Carpenter <error27@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-05-11 11:35:49 -07:00