Matthias Beyer
18002f567f
Staging: bcm: PHSModule.c: Simplified nested if statements by linking them with logical AND in GetPhsRuleEntry()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:49 -07:00
Matthias Beyer
1c53f0877e
Staging: bcm: PHSModule.c: Simplified nested if statements by linking them with logical AND in GetServiceFlowEntry()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:49 -07:00
Matthias Beyer
c842dd2ddb
Staging: bcm: PHSModule.c: Simplified nested if statements by linking them with logical AND in GetServiceFlowEntry()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:49 -07:00
Matthias Beyer
cf423564fa
Staging: bcm: PHSModule.c: Replaced member accessing with variable in GetServiceFlowEntry()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:49 -07:00
Matthias Beyer
14d8e91596
Staging: bcm: PHSModule.c: Added const keyword to ValidatePHSRUleComplete() argument
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:49 -07:00
Matthias Beyer
cc872f8070
Staging: bcm: PHSModule.c: Rewrote ValidatePHSRuleComplete()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
c8020cc93e
Staging: bcm: PHSModule.c: Replaced indentation level with goto jump on bad condition
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
3ed150a178
Staging: bcm: PHSModule.c: Replaced member accessing with variable in free_phs_service()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
b43b245fb3
Staging: bcm: PHSModule.c: Added missing braces around else block
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
babb7f9479
Staging: bcm: PHSModule.c: Whitespace cleanup in PhsCompress()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
a984b124aa
Staging: bcm: PHSModule.c: Replaced member accessing with variables
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
fc38bc1d68
Staging: bcm: PHSModule.c: Reduced indentation by using jump label in PhsDeleteSFRules()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
93cc6ae8b3
Staging: bcm: PHSModule.c: Shortened lines
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
525afdd170
Staging: bcm: PHSModule.c: Reduced indentation level by using jump label
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
31f4f3fb15
Staging: bcm: PHSModule.c: Replaced nested if statements with logical AND concatenation of the conditions
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:48 -07:00
Matthias Beyer
413852b6d4
Staging: bcm: PHSModule.c: Replaced member accessing with variable in PhsDeletePHSRule()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:47 -07:00
Matthias Beyer
c50e0b5c77
Staging: bcm: PHSModule.c: Outsourced debug printing for phs classifier entry
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:47 -07:00
Matthias Beyer
20d174e2b4
Staging: bcm: PHSModule.c: Outsourced debug printing in own function
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:47 -07:00
Matthias Beyer
ca89a2950c
Staging: bcm: PHSModule.c: Whitespace & Indentation cleanup
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-15 08:09:47 -07:00
Matthias Beyer
2349c05a61
Staging: bcm: Transmit.c: Removed obvious comment
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-12 13:21:45 -07:00
Matthias Beyer
358ed017c7
Staging: bcm: Transmit.c: Line length / Whitespace cleanup
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-12 13:21:45 -07:00
Matthias Beyer
c971681aea
Staging: bcm: Transmit.c: Replaced member accessing with variable
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-12 13:21:45 -07:00
Pawel Lebioda
89fa037b82
staging: bcm: add missing blank lines after declarations
...
Fix "Missing blank line after declaration" warnings reported by
checkpatch.pl.
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09 12:20:37 -07:00
Matthias Beyer
40e61d1279
Staging: bcm: InterfaceMisc.c: Outsourced doubled error checking
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:22:30 -07:00
Matthias Beyer
8e7e2805ef
Staging: bcm: Shortened lines
...
This patch fixes line lengths in the
drivers/staging/bcm/InterfaceMisc.c
file.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:22:30 -07:00
Kevin McKinney
970e4c4a88
Staging: bcm: Change TODO to include maintainers.
...
Add myself and Matthias Beyer
to the TODO file as the list of maintainers.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:21:55 -07:00
Matthias Beyer
66dcb017b3
Staging: bcm: LeakyBucket.c: Removed unneccessary return; statement
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:21:14 -07:00
Matthias Beyer
504d33d5fb
Staging: bcm: LeakyBucket.c: Outsourced ctrl packet sending
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:21:14 -07:00
Matthias Beyer
b61124f99d
Staging: bcm: LeakyBucket.c: Outsourced code chunk into function
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:21:14 -07:00
Matthias Beyer
0acfe734fa
Staging: bcm: LeakyBucket.c: Shortened lines
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:21:14 -07:00
Matthias Beyer
f1220c7d6b
Staging: bcm: LeakyBucket.c: Replaced member accessing by variable
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:21:14 -07:00
Matthias Beyer
792d921107
Staging: bcm: InterfaceTx.c: checkpath fix: Blank line after declarations
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:20:25 -07:00
Matthias Beyer
26fba8e4e5
Staging: bcm: InterfaceTx.c: Outsourced code chunk
...
This patch outsources a chunk of code into an own function and refactors
the variable names inside the new function.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:20:25 -07:00
Matthias Beyer
5faf33007f
Staging: bcm: InterfaceTx.c: Shortened lines + Whitespace cleanup
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:20:25 -07:00
Matthias Beyer
8139b8d535
Staging: bcm: InterfaceRx.c: Removed unused variable
...
This patch removes the `process_done` variable from both
format_eth_hdr_to_stack() and read_bulk_callback() (where it is
declared), as it is not used anywhere (it is set in the
format_eth_hdr_to_stack() function, but afterwards not used).
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:06:16 -07:00
Matthias Beyer
3a162b1948
Staging: bcm: InterfaceRx.c: Outsourced code chunk
...
This patch outsources a chunk of code into a function.
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:06:16 -07:00
Matthias Beyer
c6346fafd1
Staging: bcm: InterfaceRx.c: Outsourced control packet handling
...
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:06:16 -07:00
Matthias Beyer
f5c86ab9b6
Staging: bcm: InterfaceRx.c: Lines shortened
...
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 16:06:16 -07:00
Matthias Beyer
39874a0c75
Staging: bcm: Lines shortened in download_ddr_settings()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29 14:29:42 -07:00
Matthias Beyer
9d6f394505
Staging: bcm: Lines shortened in ddr_init()
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29 14:29:42 -07:00
Matthias Beyer
40ee5a77ee
Staging: bcm: Moved doubled if-block
...
This patch moves the doubled if block inside the retval-checking one
level up.
As the if-else-block it was in is now a one-statement if-else block,
I removed the braces from it.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29 14:29:42 -07:00
Matthias Beyer
71928b3a46
Staging: bcm: Fixed indention for inner if-block
...
The inner if-statement was aligned just like the outer one. Why?
This indention was introduced by
f34c488c38
which is a indention-fix patch itself. That's why I'm curious about it.
I did not merge these nested if-statements, as I don't know if I'm
destroying logical seperated checks with it.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29 14:29:41 -07:00
Matthias Beyer
41f3b52cf4
Staging: bcm: Indentation fixes
...
This patch fixes some indentation errors, where multi-line statements
where not indented.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29 14:29:41 -07:00
Matthias Beyer
ccc5188a9a
Staging: bcm: Misc whitespace fixes
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29 14:29:41 -07:00
Rickard Strandqvist
c0cd6e5b1f
staging: bcm: nvm.c: Cleaning up check unsigned is less than zero
...
Remove checking if a unsigned int is less than zero
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 21:08:46 -04:00
Matthias Beyer
fa1e4a7f09
Staging: bcm: hostmibs.c: Shortened lines
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Jake Edge <jake@lwn.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 21:06:35 -04:00
Matthias Beyer
ecf974451d
Staging: bcm: replaced member accessing with variable for readability
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Reviewed-by: Jake Edge <jake@lwn.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 21:06:35 -04:00
Matthias Beyer
f687299f31
Staging: bcm: Added missing blank line after declarations
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 21:05:13 -04:00
Matthias Beyer
ab78899a0e
Staging: bcm: Replaced member accssing with variable
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 21:05:13 -04:00
Matthias Beyer
55eb46e960
Staging: bcm: Whitespace for indentation fixed
...
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 21:05:13 -04:00