system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-22 11:19:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: gadget: mv_u3d_core: fix memory leaks

Browse source 
When trb_hw is NULL, trb should be free'd before return.

Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Valentin Ilie 2013-09-21 12:30:15 +03:00 committed by Felipe Balbi
parent 161bfa98ba
commit f51a08da6d
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/usb/gadget/mv_u3d_core.c
View file

@ -310,6 +310,7 @@ static struct mv_u3d_trb *mv_u3d_build_trb_one(struct mv_u3d_req *req,
*/ */
trb_hw = dma_pool_alloc(u3d->trb_pool, GFP_ATOMIC, dma); trb_hw = dma_pool_alloc(u3d->trb_pool, GFP_ATOMIC, dma);
if (!trb_hw) { if (!trb_hw) {
kfree(trb);
dev_err(u3d->dev, dev_err(u3d->dev,
"%s, dma_pool_alloc fail\n", __func__); "%s, dma_pool_alloc fail\n", __func__);
return NULL; return NULL;
@ -454,6 +455,7 @@ static int mv_u3d_req_to_trb(struct mv_u3d_req *req)
trb_hw = kcalloc(trb_num, sizeof(*trb_hw), GFP_ATOMIC); trb_hw = kcalloc(trb_num, sizeof(*trb_hw), GFP_ATOMIC);
if (!trb_hw) { if (!trb_hw) {
kfree(trb);
dev_err(u3d->dev, dev_err(u3d->dev,
"%s, trb_hw alloc fail\n", __func__); "%s, trb_hw alloc fail\n", __func__);
return -ENOMEM; return -ENOMEM;