mirror of
https://github.com/torvalds/linux
synced 2024-09-06 09:51:23 +00:00
ALSA: aoa: onyx: always initialize register read value
A lot of places in the driver use onyx_read_register() without
checking the return value, and it's been working OK for ~10 years
or so, so probably never fails ... Rather than trying to check the
return value everywhere, which would be relatively intrusive, at
least make sure we don't use an uninitialized value.
Fixes: f3d9478b2c
("[ALSA] snd-aoa: add snd-aoa")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
9e4d5c1be2
commit
f474808acb
|
@ -71,8 +71,10 @@ static int onyx_read_register(struct onyx *onyx, u8 reg, u8 *value)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
v = i2c_smbus_read_byte_data(onyx->i2c, reg);
|
v = i2c_smbus_read_byte_data(onyx->i2c, reg);
|
||||||
if (v < 0)
|
if (v < 0) {
|
||||||
|
*value = 0;
|
||||||
return -1;
|
return -1;
|
||||||
|
}
|
||||||
*value = (u8)v;
|
*value = (u8)v;
|
||||||
onyx->cache[ONYX_REG_CONTROL-FIRSTREGISTER] = *value;
|
onyx->cache[ONYX_REG_CONTROL-FIRSTREGISTER] = *value;
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Loading…
Reference in a new issue