system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-20 18:28:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

serial: 8250_early: confirm empty transmitter after sending characters

Browse source 
The current code waits until the transmitter becomes empty,
before sending each character, and after finishing the whole string.
This seems a bit redundant.

It can be more efficient by checking the transmitter only after sending
each character.  This should be safe because the transmitter is already
empty at the first entry of serial_putc().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Masahiro Yamada 2015-10-30 11:39:04 +09:00 committed by Greg Kroah-Hartman
parent 2cda227bba
commit f2bfdb0628
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/tty/serial/8250/8250_early.c
View file

@ -87,8 +87,8 @@ static void __init wait_for_xmitr(struct uart_port *port)
static void __init serial_putc(struct uart_port *port, int c)
{
wait_for_xmitr(port);
serial8250_early_out(port, UART_TX, c);
wait_for_xmitr(port);
}
static void __init early_serial8250_write(struct console *console,
@ -98,9 +98,6 @@ static void __init early_serial8250_write(struct console *console,
struct uart_port *port = &device->port;
uart_console_write(port, s, count, serial_putc);
/* Wait for transmitter to become empty */
wait_for_xmitr(port);
}
static void __init init_port(struct earlycon_device *device)