media: venus: Add debugfs interface to set firmware log level

This will be useful when debugging specific issues related to
firmware HFI interface.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Stanimir Varbanov 2020-05-21 13:35:16 +02:00 committed by Mauro Carvalho Chehab
parent 8b6a1010af
commit f08abe6a1e
6 changed files with 45 additions and 2 deletions

View file

@ -3,7 +3,7 @@
venus-core-objs += core.o helpers.o firmware.o \
hfi_venus.o hfi_msgs.o hfi_cmds.o hfi.o \
hfi_parser.o pm_helpers.o
hfi_parser.o pm_helpers.o dbgfs.o
venus-dec-objs += vdec.o vdec_ctrls.o
venus-enc-objs += venc.o venc_ctrls.o

View file

@ -295,6 +295,8 @@ static int venus_probe(struct platform_device *pdev)
goto err_dev_unregister;
}
venus_dbgfs_init(core);
return 0;
err_dev_unregister:
@ -346,6 +348,7 @@ static int venus_remove(struct platform_device *pdev)
v4l2_device_unregister(&core->v4l2_dev);
mutex_destroy(&core->pm_lock);
mutex_destroy(&core->lock);
venus_dbgfs_deinit(core);
return ret;
}

View file

@ -12,6 +12,7 @@
#include <media/v4l2-ctrls.h>
#include <media/v4l2-device.h>
#include "dbgfs.h"
#include "hfi.h"
#define VIDC_CLKS_NUM_MAX 4
@ -137,6 +138,7 @@ struct venus_caps {
* @priv: a private filed for HFI operations
* @ops: the core HFI operations
* @work: a delayed work for handling system fatal error
* @root: debugfs root directory
*/
struct venus_core {
void __iomem *base;
@ -190,6 +192,7 @@ struct venus_core {
unsigned int codecs_count;
unsigned int core0_usage_count;
unsigned int core1_usage_count;
struct dentry *root;
};
struct vdec_controls {

View file

@ -0,0 +1,21 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (C) 2020 Linaro Ltd.
*/
#include <linux/debugfs.h>
#include "core.h"
extern int venus_fw_debug;
void venus_dbgfs_init(struct venus_core *core)
{
core->root = debugfs_create_dir("venus", NULL);
debugfs_create_x32("fw_level", 0644, core->root, &venus_fw_debug);
}
void venus_dbgfs_deinit(struct venus_core *core)
{
debugfs_remove_recursive(core->root);
}

View file

@ -0,0 +1,12 @@
/* SPDX-License-Identifier: GPL-2.0 */
/* Copyright (C) 2020 Linaro Ltd. */
#ifndef __VENUS_DBGFS_H__
#define __VENUS_DBGFS_H__
struct venus_core;
void venus_dbgfs_init(struct venus_core *core);
void venus_dbgfs_deinit(struct venus_core *core);
#endif

View file

@ -130,7 +130,7 @@ struct venus_hfi_device {
};
static bool venus_pkt_debug;
static int venus_fw_debug = HFI_DEBUG_MSG_ERROR | HFI_DEBUG_MSG_FATAL;
int venus_fw_debug = HFI_DEBUG_MSG_ERROR | HFI_DEBUG_MSG_FATAL;
static bool venus_sys_idle_indicator;
static bool venus_fw_low_power_mode = true;
static int venus_hw_rsp_timeout = 1000;
@ -1122,6 +1122,10 @@ static int venus_session_init(struct venus_inst *inst, u32 session_type,
struct hfi_session_init_pkt pkt;
int ret;
ret = venus_sys_set_debug(hdev, venus_fw_debug);
if (ret)
goto err;
ret = pkt_session_init(&pkt, inst, session_type, codec);
if (ret)
goto err;