system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-19 17:58:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

USB: serial: ftdi_sio: fix gpio name collisions

Browse source 
Drop the gpio line names, which cause gpiolib to complain loudly
whenever a second ftdi gpiochip is registered:

	gpio gpiochip5: Detected name collision for GPIO name 'CBUS0'
	gpio gpiochip5: Detected name collision for GPIO name 'CBUS1'
	gpio gpiochip5: Detected name collision for GPIO name 'CBUS2'
	gpio gpiochip5: Detected name collision for GPIO name 'CBUS3'

and also prevents the legacy sysfs interface from being used (as the
line names are used as device names whenever they are set):

	sysfs: cannot create duplicate filename '/class/gpio/CBUS0'

Until non-unique names are supported by gpiolib (without warnings and
stack dumps), let's leave the gpio lines unnamed.

Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Johan Hovold 2018-09-30 14:27:02 +02:00
parent ba93cc7da8
commit e0658e3074
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/usb/serial/ftdi_sio.c
View file

@ -1778,10 +1778,6 @@ static void remove_sysfs_attrs(struct usb_serial_port *port)
#ifdef CONFIG_GPIOLIB
static const char * const ftdi_ftx_gpio_names[] = {
"CBUS0", "CBUS1", "CBUS2", "CBUS3"
};
static int ftdi_set_bitmode(struct usb_serial_port *port, u8 mode)
{
struct ftdi_private *priv = usb_get_serial_port_data(port);
@ -2032,7 +2028,6 @@ static int ftx_gpioconf_init(struct usb_serial_port *port)
/* FIXME: FT234XD alone has 1 GPIO, but how to recognize this IC? */
priv->gc.ngpio = 4;
priv->gc.names = ftdi_ftx_gpio_names;
/* Determine which pins are configured for CBUS bitbanging */
priv->gpio_altfunc = 0xff;