mirror of
https://github.com/torvalds/linux
synced 2024-10-15 07:47:34 +00:00
KVM: WARN if there are dangling MMU invalidations at VM destruction
Add an assertion that there are no in-progress MMU invalidations when a VM is being destroyed, with the exception of the scenario where KVM unregisters its MMU notifier between an .invalidate_range_start() call and the corresponding .invalidate_range_end(). KVM can't detect unpaired calls from the mmu_notifier due to the above exception waiver, but the assertion can detect KVM bugs, e.g. such as the bug that *almost* escaped initial guest_memfd development. Link: https://lore.kernel.org/all/e397d30c-c6af-e68f-d18e-b4e3739c5389@linux.intel.com Signed-off-by: Sean Christopherson <seanjc@google.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Fuad Tabba <tabba@google.com> Tested-by: Fuad Tabba <tabba@google.com> Message-Id: <20231027182217.3615211-5-seanjc@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
parent
8569992d64
commit
d497a0fab8
|
@ -1358,9 +1358,16 @@ static void kvm_destroy_vm(struct kvm *kvm)
|
||||||
* No threads can be waiting in kvm_swap_active_memslots() as the
|
* No threads can be waiting in kvm_swap_active_memslots() as the
|
||||||
* last reference on KVM has been dropped, but freeing
|
* last reference on KVM has been dropped, but freeing
|
||||||
* memslots would deadlock without this manual intervention.
|
* memslots would deadlock without this manual intervention.
|
||||||
|
*
|
||||||
|
* If the count isn't unbalanced, i.e. KVM did NOT unregister its MMU
|
||||||
|
* notifier between a start() and end(), then there shouldn't be any
|
||||||
|
* in-progress invalidations.
|
||||||
*/
|
*/
|
||||||
WARN_ON(rcuwait_active(&kvm->mn_memslots_update_rcuwait));
|
WARN_ON(rcuwait_active(&kvm->mn_memslots_update_rcuwait));
|
||||||
kvm->mn_active_invalidate_count = 0;
|
if (kvm->mn_active_invalidate_count)
|
||||||
|
kvm->mn_active_invalidate_count = 0;
|
||||||
|
else
|
||||||
|
WARN_ON(kvm->mmu_invalidate_in_progress);
|
||||||
#else
|
#else
|
||||||
kvm_flush_shadow_all(kvm);
|
kvm_flush_shadow_all(kvm);
|
||||||
#endif
|
#endif
|
||||||
|
|
Loading…
Reference in a new issue