mirror of
https://github.com/torvalds/linux
synced 2024-10-04 10:26:40 +00:00
ext4: fix error handling code in add_new_gdb
When ext4_journal_get_write_access() fails, we should terminate the execution flow and release n_group_desc, iloc.bh, dind and gdb_bh. Cc: stable@kernel.org Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Andreas Dilger <adilger@dilger.ca> Link: https://lore.kernel.org/r/20200829025403.3139-1-dinghao.liu@zju.edu.cn Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
parent
aa2f77920b
commit
c9e87161cc
|
@ -843,8 +843,10 @@ static int add_new_gdb(handle_t *handle, struct inode *inode,
|
||||||
|
|
||||||
BUFFER_TRACE(dind, "get_write_access");
|
BUFFER_TRACE(dind, "get_write_access");
|
||||||
err = ext4_journal_get_write_access(handle, dind);
|
err = ext4_journal_get_write_access(handle, dind);
|
||||||
if (unlikely(err))
|
if (unlikely(err)) {
|
||||||
ext4_std_error(sb, err);
|
ext4_std_error(sb, err);
|
||||||
|
goto errout;
|
||||||
|
}
|
||||||
|
|
||||||
/* ext4_reserve_inode_write() gets a reference on the iloc */
|
/* ext4_reserve_inode_write() gets a reference on the iloc */
|
||||||
err = ext4_reserve_inode_write(handle, inode, &iloc);
|
err = ext4_reserve_inode_write(handle, inode, &iloc);
|
||||||
|
|
Loading…
Reference in a new issue