system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-05 02:44:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm/gpuvm: Let drm_gpuvm_bo_put() report when the vm_bo object is destroyed

Browse source 
Some users need to release resources attached to the vm_bo object when
it's destroyed. In Panthor's case, we need to release the pin ref so
BO pages can be returned to the system when all GPU mappings are gone.

This could be done through a custom drm_gpuvm::vm_bo_free() hook, but
this has all sort of locking implications that would force us to expose
a drm_gem_shmem_unpin_locked() helper, not to mention the fact that
having a ::vm_bo_free() implementation without a ::vm_bo_alloc() one
seems odd. So let's keep things simple, and extend drm_gpuvm_bo_put()
to report when the object is destroyed.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231204151406.1977285-1-boris.brezillon@collabora.com
This commit is contained in:
Boris Brezillon 2023-12-04 16:14:06 +01:00
parent 157ad4ccff
commit c50a291d62
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/gpu/drm/drm_gpuvm.c
View file

@ -1535,14 +1535,18 @@ drm_gpuvm_bo_destroy(struct kref *kref)
* hold the dma-resv or driver specific GEM gpuva lock. * hold the dma-resv or driver specific GEM gpuva lock.
* *
* This function may only be called from non-atomic context. * This function may only be called from non-atomic context.
*
* Returns: true if vm_bo was destroyed, false otherwise.
*/ */
void bool
drm_gpuvm_bo_put(struct drm_gpuvm_bo *vm_bo) drm_gpuvm_bo_put(struct drm_gpuvm_bo *vm_bo)
{ {
might_sleep(); might_sleep();
if (vm_bo) if (vm_bo)
kref_put(&vm_bo->kref, drm_gpuvm_bo_destroy); return !!kref_put(&vm_bo->kref, drm_gpuvm_bo_destroy);
return false;
} }
EXPORT_SYMBOL_GPL(drm_gpuvm_bo_put); EXPORT_SYMBOL_GPL(drm_gpuvm_bo_put);

2
include/drm/drm_gpuvm.h
View file

@ -721,7 +721,7 @@ drm_gpuvm_bo_get(struct drm_gpuvm_bo *vm_bo)
return vm_bo; return vm_bo;
} }
void drm_gpuvm_bo_put(struct drm_gpuvm_bo *vm_bo); bool drm_gpuvm_bo_put(struct drm_gpuvm_bo *vm_bo);
struct drm_gpuvm_bo * struct drm_gpuvm_bo *
drm_gpuvm_bo_find(struct drm_gpuvm *gpuvm, drm_gpuvm_bo_find(struct drm_gpuvm *gpuvm,