mirror of
https://github.com/torvalds/linux
synced 2024-10-01 08:50:11 +00:00
ASoC: stm: stm32_spdifrx: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Takashi Iwai <tiwai@suse.de> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Link: https://lore.kernel.org/r/20230315150745.67084-140-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
a3bd37e2e2
commit
c4d4ce48f8
|
@ -939,7 +939,7 @@ static int stm32_spdifrx_parse_of(struct platform_device *pdev,
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int stm32_spdifrx_remove(struct platform_device *pdev)
|
static void stm32_spdifrx_remove(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
struct stm32_spdifrx_data *spdifrx = platform_get_drvdata(pdev);
|
struct stm32_spdifrx_data *spdifrx = platform_get_drvdata(pdev);
|
||||||
|
|
||||||
|
@ -952,8 +952,6 @@ static int stm32_spdifrx_remove(struct platform_device *pdev)
|
||||||
snd_dmaengine_pcm_unregister(&pdev->dev);
|
snd_dmaengine_pcm_unregister(&pdev->dev);
|
||||||
snd_soc_unregister_component(&pdev->dev);
|
snd_soc_unregister_component(&pdev->dev);
|
||||||
pm_runtime_disable(&pdev->dev);
|
pm_runtime_disable(&pdev->dev);
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static int stm32_spdifrx_probe(struct platform_device *pdev)
|
static int stm32_spdifrx_probe(struct platform_device *pdev)
|
||||||
|
@ -1078,7 +1076,7 @@ static struct platform_driver stm32_spdifrx_driver = {
|
||||||
.pm = &stm32_spdifrx_pm_ops,
|
.pm = &stm32_spdifrx_pm_ops,
|
||||||
},
|
},
|
||||||
.probe = stm32_spdifrx_probe,
|
.probe = stm32_spdifrx_probe,
|
||||||
.remove = stm32_spdifrx_remove,
|
.remove_new = stm32_spdifrx_remove,
|
||||||
};
|
};
|
||||||
|
|
||||||
module_platform_driver(stm32_spdifrx_driver);
|
module_platform_driver(stm32_spdifrx_driver);
|
||||||
|
|
Loading…
Reference in a new issue