system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-11-05 18:23:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

coresight: "DEVICE_ATTR_RO" should defined as static.

Browse source 
"DEVICE_ATTR_RO(name)" should be defined as static. And
there is an unnecessary space at the front of the code.

The sparse tool output logs as the following:
coresight-etm4x.c:2224:1: warning: symbol 'dev_attr_trcoslsr' was
not declared. Should it be static?
coresight-etm4x.c:2225:1: warning: symbol 'dev_attr_trcpdcr' was
not declared. Should it be static?
coresight-etm4x.c:2226:1: warning: symbol 'dev_attr_trcpdsr' was
not declared. Should it be static?
And the smatch tool output logs as the following:
of_coresight.c:89 of_coresight_alloc_memory() warn:
inconsistent indenting

Signed-off-by: Eric Long <eric.long@linaro.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Eric Long 2016-02-17 17:51:43 -07:00 committed by Greg Kroah-Hartman
parent adcde635f5
commit bf16e5b8cd
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/hwtracing/coresight/coresight-etm4x.c
View file

@ -2227,7 +2227,7 @@ static ssize_t name##_show(struct device *_dev, \
return scnprintf(buf, PAGE_SIZE, "0x%x\n", \ return scnprintf(buf, PAGE_SIZE, "0x%x\n", \
readl_relaxed(drvdata->base + offset)); \ readl_relaxed(drvdata->base + offset)); \
} \ } \
DEVICE_ATTR_RO(name) static DEVICE_ATTR_RO(name)
coresight_simple_func(trcoslsr, TRCOSLSR); coresight_simple_func(trcoslsr, TRCOSLSR);
coresight_simple_func(trcpdcr, TRCPDCR); coresight_simple_func(trcpdcr, TRCPDCR);

2
drivers/hwtracing/coresight/of_coresight.c
View file

@ -86,7 +86,7 @@ static int of_coresight_alloc_memory(struct device *dev,
return -ENOMEM; return -ENOMEM;
/* Children connected to this component via @outports */ /* Children connected to this component via @outports */
pdata->child_names = devm_kzalloc(dev, pdata->nr_outport * pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
sizeof(*pdata->child_names), sizeof(*pdata->child_names),
GFP_KERNEL); GFP_KERNEL);
if (!pdata->child_names) if (!pdata->child_names)