mirror of
https://github.com/torvalds/linux
synced 2024-10-16 16:29:20 +00:00
fbdev/hpfb: Initialize fb_ops to fbdev I/O-memory helpers
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the callbacks being NULL for a default implementation to be invoked; hence requiring the I/O helpers to be built in any case. Setting all callbacks in all drivers explicitly will allow to make the I/O helpers optional. This benefits systems that do not use these functions. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-19-tzimmermann@suse.de
This commit is contained in:
parent
a1a1c3fa13
commit
b933456c25
|
@ -407,6 +407,7 @@ config FB_HP300
|
||||||
bool
|
bool
|
||||||
depends on (FB = y) && DIO
|
depends on (FB = y) && DIO
|
||||||
select FB_CFB_IMAGEBLIT
|
select FB_CFB_IMAGEBLIT
|
||||||
|
select FB_IOMEM_FOPS
|
||||||
default y
|
default y
|
||||||
|
|
||||||
config FB_TGA
|
config FB_TGA
|
||||||
|
|
|
@ -186,12 +186,14 @@ static int hpfb_sync(struct fb_info *info)
|
||||||
|
|
||||||
static const struct fb_ops hpfb_ops = {
|
static const struct fb_ops hpfb_ops = {
|
||||||
.owner = THIS_MODULE,
|
.owner = THIS_MODULE,
|
||||||
|
__FB_DEFAULT_IOMEM_OPS_RDWR,
|
||||||
.fb_setcolreg = hpfb_setcolreg,
|
.fb_setcolreg = hpfb_setcolreg,
|
||||||
.fb_blank = hpfb_blank,
|
.fb_blank = hpfb_blank,
|
||||||
.fb_fillrect = hpfb_fillrect,
|
.fb_fillrect = hpfb_fillrect,
|
||||||
.fb_copyarea = hpfb_copyarea,
|
.fb_copyarea = hpfb_copyarea,
|
||||||
.fb_imageblit = cfb_imageblit,
|
.fb_imageblit = cfb_imageblit,
|
||||||
.fb_sync = hpfb_sync,
|
.fb_sync = hpfb_sync,
|
||||||
|
__FB_DEFAULT_IOMEM_OPS_MMAP,
|
||||||
};
|
};
|
||||||
|
|
||||||
/* Common to all HP framebuffers */
|
/* Common to all HP framebuffers */
|
||||||
|
|
Loading…
Reference in a new issue