system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-11-05 18:23:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

iser-target: Fix error path in isert_create_pi_ctx()

Browse source 
We don't assign pi_ctx to desc->pi_ctx until we're certain to succeed
in the function.  That means the cleanup path should use the local
pi_ctx variable, not desc->pi_ctx.

This was detected by Coverity (CID 1260062).

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Roland Dreier 2015-05-29 23:12:10 -07:00 committed by Nicholas Bellinger
parent a3541703eb
commit b2feda4feb
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/infiniband/ulp/isert/ib_isert.c
View file

@ -547,11 +547,11 @@ isert_create_pi_ctx(struct fast_reg_descriptor *desc,
return 0; return 0;
err_prot_mr: err_prot_mr:
ib_dereg_mr(desc->pi_ctx->prot_mr); ib_dereg_mr(pi_ctx->prot_mr);
err_prot_frpl: err_prot_frpl:
ib_free_fast_reg_page_list(desc->pi_ctx->prot_frpl); ib_free_fast_reg_page_list(pi_ctx->prot_frpl);
err_pi_ctx: err_pi_ctx:
kfree(desc->pi_ctx); kfree(pi_ctx);
return ret; return ret;
} }