mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
net_sched: gen_estimator: fix broken estimators based on percpu stats
pfifo_fast got percpu stats lately, uncovering a bug I introduced last
year in linux-4.10.
I missed the fact that we have to clear our temporary storage
before calling __gnet_stats_copy_basic() in the case of percpu stats.
Without this fix, rate estimators (tc qd replace dev xxx root est 1sec
4sec pfifo_fast) are utterly broken.
Fixes: 1c0d32fde5
("net_sched: gen_estimator: complete rewrite of rate estimators")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
2217009443
commit
a5f7add332
|
@ -66,6 +66,7 @@ struct net_rate_estimator {
|
|||
static void est_fetch_counters(struct net_rate_estimator *e,
|
||||
struct gnet_stats_basic_packed *b)
|
||||
{
|
||||
memset(b, 0, sizeof(*b));
|
||||
if (e->stats_lock)
|
||||
spin_lock(e->stats_lock);
|
||||
|
||||
|
|
Loading…
Reference in a new issue