system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-29 16:00:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: pci_endpoint_test: Avoid triggering a BUG()

Browse source 
If you call ida_simple_remove(&pci_endpoint_test_ida, id) with a negative
"id" then it triggers an immediate BUG_ON().  Let's not allow that.

Fixes: 2c156ac71c ("misc: Add host side PCI driver for PCI test function device")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
This commit is contained in:
Dan Carpenter 2017-09-30 11:16:51 +03:00 committed by Bjorn Helgaas
parent 343dc693f7
commit a2db2663bd
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/misc/pci_endpoint_test.c
View file

@ -597,6 +597,8 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
if (sscanf(misc_device->name, DRV_MODULE_NAME ".%d", &id) != 1) if (sscanf(misc_device->name, DRV_MODULE_NAME ".%d", &id) != 1)
return; return;
if (id < 0)
return;
misc_deregister(&test->miscdev); misc_deregister(&test->miscdev);
ida_simple_remove(&pci_endpoint_test_ida, id); ida_simple_remove(&pci_endpoint_test_ida, id);