system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-18 17:29:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: rsnd: indicate unknown error at rsnd_dai_call()

Browse source 
Current rsnd_dai_call() doesn't indicate error message,
thus it is very difficult to know the issue
when strange things happen.
This patch indicates error for it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Message-Id: <871r9snbji.wl-kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Kuninori Morimoto 2021-05-27 11:41:21 +09:00 committed by Mark Brown
parent 54e81e9446
commit 9ff07d19fb
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sound/soc/sh/rcar/core.c
View file

@ -543,7 +543,7 @@ static int rsnd_status_update(u32 *status,
int func_call = (val == timing);
if (next_val == 0xF) /* underflow case */
func_call = 0;
func_call = -1;
else
*status = (*status & ~mask) + (next_val << shift);
@ -567,11 +567,12 @@ static int rsnd_status_update(u32 *status,
rsnd_dbg_dai_call(dev, "%s\t0x%08x %s\n", \
rsnd_mod_name(mod), *status, \
(func_call && (mod)->ops->fn) ? #fn : ""); \
if (func_call && (mod)->ops->fn) \
if (func_call > 0 && (mod)->ops->fn) \
tmp = (mod)->ops->fn(mod, io, param); \
if (tmp && (tmp != -EPROBE_DEFER)) \
dev_err(dev, "%s : %s error %d\n", \
rsnd_mod_name(mod), #fn, tmp); \
if (unlikely(func_call < 0) || \
unlikely(tmp && (tmp != -EPROBE_DEFER))) \
dev_err(dev, "%s : %s error (%d, %d)\n", \
rsnd_mod_name(mod), #fn, tmp, func_call);\
ret |= tmp; \
} \
ret; \