mirror of
https://github.com/torvalds/linux
synced 2024-09-21 11:38:48 +00:00
scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work
clang warns: drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case IBMVSCSI_HOST_ACTION_NONE: ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized use occurs here if (rc) { ^~ Initialize rc in the IBMVSCSI_HOST_ACTION_UNBLOCK case statement then shuffle IBMVSCSI_HOST_ACTION_NONE down to the default case statement and make it return early so that rc is never used uninitialized in this function. Fixes: 035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states") Link: https://github.com/ClangBuiltLinux/linux/issues/502 Suggested-by: Michael Ellerman <mpe@ellerman.id.au> Suggested-by: Tyrel Datwyler <tyreld@linux.ibm.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
d7b761b069
commit
961ed94e8a
|
@ -2123,8 +2123,8 @@ static void ibmvscsi_do_work(struct ibmvscsi_host_data *hostdata)
|
||||||
|
|
||||||
spin_lock_irqsave(hostdata->host->host_lock, flags);
|
spin_lock_irqsave(hostdata->host->host_lock, flags);
|
||||||
switch (hostdata->action) {
|
switch (hostdata->action) {
|
||||||
case IBMVSCSI_HOST_ACTION_NONE:
|
|
||||||
case IBMVSCSI_HOST_ACTION_UNBLOCK:
|
case IBMVSCSI_HOST_ACTION_UNBLOCK:
|
||||||
|
rc = 0;
|
||||||
break;
|
break;
|
||||||
case IBMVSCSI_HOST_ACTION_RESET:
|
case IBMVSCSI_HOST_ACTION_RESET:
|
||||||
spin_unlock_irqrestore(hostdata->host->host_lock, flags);
|
spin_unlock_irqrestore(hostdata->host->host_lock, flags);
|
||||||
|
@ -2142,8 +2142,10 @@ static void ibmvscsi_do_work(struct ibmvscsi_host_data *hostdata)
|
||||||
if (!rc)
|
if (!rc)
|
||||||
rc = ibmvscsi_send_crq(hostdata, 0xC001000000000000LL, 0);
|
rc = ibmvscsi_send_crq(hostdata, 0xC001000000000000LL, 0);
|
||||||
break;
|
break;
|
||||||
|
case IBMVSCSI_HOST_ACTION_NONE:
|
||||||
default:
|
default:
|
||||||
break;
|
spin_unlock_irqrestore(hostdata->host->host_lock, flags);
|
||||||
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
hostdata->action = IBMVSCSI_HOST_ACTION_NONE;
|
hostdata->action = IBMVSCSI_HOST_ACTION_NONE;
|
||||||
|
|
Loading…
Reference in a new issue