system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-20 02:57:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

[media] gpio-ir-recv: a couple signedness bugs

Browse source 
There are couple places where we check unsigned values for negative.  I
changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
        if (pdata->gpio_nr < 0)
                return -EINVAL;
I also change gval to a signed int in gpio_ir_recv_irq() because that's
the type that gpio_get_value_cansleep() returns and we test for negative
returns.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Trilok Soni <tsoni@codeaurora.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2012-03-10 04:58:18 -03:00 committed by Mauro Carvalho Chehab
parent 23bfb5be9f
commit 955b44304a
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/media/rc/gpio-ir-recv.c
View file

@ -26,14 +26,14 @@
struct gpio_rc_dev {
struct rc_dev *rcdev;
unsigned int gpio_nr;
int gpio_nr;
bool active_low;
};
static irqreturn_t gpio_ir_recv_irq(int irq, void *dev_id)
{
struct gpio_rc_dev *gpio_dev = dev_id;
unsigned int gval;
int gval;
int rc = 0;
enum raw_event_type type = IR_SPACE;

2
include/media/gpio-ir-recv.h
View file

@ -14,7 +14,7 @@
#define __GPIO_IR_RECV_H__
struct gpio_ir_recv_platform_data {
unsigned int gpio_nr;
int gpio_nr;
bool active_low;
};