system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-21 03:28:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

mmc: dw_mmc: brackets in register access macros

Browse source 
Add brackets around use of the dev argument to the
mci_{read,write}{w,l,q}() macros, for extra safety.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Will Newton <will.newton@imgtec.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
This commit is contained in:
James Hogan 2011-06-24 13:56:38 +01:00 committed by Chris Ball
parent 1791b13ea4
commit 892b1e312b
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/mmc/host/dw_mmc.h
View file

@ -134,22 +134,22 @@
/* Register access macros */ /* Register access macros */
#define mci_readl(dev, reg) \ #define mci_readl(dev, reg) \
__raw_readl(dev->regs + SDMMC_##reg) __raw_readl((dev)->regs + SDMMC_##reg)
#define mci_writel(dev, reg, value) \ #define mci_writel(dev, reg, value) \
__raw_writel((value), dev->regs + SDMMC_##reg) __raw_writel((value), (dev)->regs + SDMMC_##reg)
/* 16-bit FIFO access macros */ /* 16-bit FIFO access macros */
#define mci_readw(dev, reg) \ #define mci_readw(dev, reg) \
__raw_readw(dev->regs + SDMMC_##reg) __raw_readw((dev)->regs + SDMMC_##reg)
#define mci_writew(dev, reg, value) \ #define mci_writew(dev, reg, value) \
__raw_writew((value), dev->regs + SDMMC_##reg) __raw_writew((value), (dev)->regs + SDMMC_##reg)
/* 64-bit FIFO access macros */ /* 64-bit FIFO access macros */
#ifdef readq #ifdef readq
#define mci_readq(dev, reg) \ #define mci_readq(dev, reg) \
__raw_readq(dev->regs + SDMMC_##reg) __raw_readq((dev)->regs + SDMMC_##reg)
#define mci_writeq(dev, reg, value) \ #define mci_writeq(dev, reg, value) \
__raw_writeq((value), dev->regs + SDMMC_##reg) __raw_writeq((value), (dev)->regs + SDMMC_##reg)
#else #else
/* /*
* Dummy readq implementation for architectures that don't define it. * Dummy readq implementation for architectures that don't define it.
@ -160,9 +160,9 @@
* rest of the code free from ifdefs. * rest of the code free from ifdefs.
*/ */
#define mci_readq(dev, reg) \ #define mci_readq(dev, reg) \
(*(volatile u64 __force *)(dev->regs + SDMMC_##reg)) (*(volatile u64 __force *)((dev)->regs + SDMMC_##reg))
#define mci_writeq(dev, reg, value) \ #define mci_writeq(dev, reg, value) \
(*(volatile u64 __force *)(dev->regs + SDMMC_##reg) = value) (*(volatile u64 __force *)((dev)->regs + SDMMC_##reg) = (value))
#endif #endif
#endif /* _DW_MMC_H_ */ #endif /* _DW_MMC_H_ */