system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-21 03:28:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

SO_ZEROCOPY should return -EOPNOTSUPP rather than -ENOTSUPP

Browse source 
ENOTSUPP is documented as "should never be seen by user programs",
and thus not exposed in <errno.h>, and thus applications cannot safely
check against it (they get "Unknown error 524" as strerror). We should
rather return the well-known -EOPNOTSUPP.

This is similar to 2230a7ef51 ("drop_monitor: Use correct error
code") and 4a5cdc604b ("net/tls: Fix return values to avoid
ENOTSUPP"), which did not seem to cause problems.

Signed-off-by: Samuel Thibault <samuel.thibault@labri.fr>
Acked-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20220307223126.djzvg44v2o2jkjsx@begin
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Samuel Thibault 2022-03-07 23:31:26 +01:00 committed by Jakub Kicinski
parent 964efdab03
commit 869420a8be
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/core/sock.c
View file

@ -1377,9 +1377,9 @@ int sock_setsockopt(struct socket *sock, int level, int optname,
if (!(sk_is_tcp(sk) ||
(sk->sk_type == SOCK_DGRAM &&
sk->sk_protocol == IPPROTO_UDP)))
ret = -ENOTSUPP;
ret = -EOPNOTSUPP;
} else if (sk->sk_family != PF_RDS) {
ret = -ENOTSUPP;
ret = -EOPNOTSUPP;
}
if (!ret) {
if (val < 0 || val > 1)