system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-20 18:28:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: wfx: prefer ARRAY_SIZE instead of a magic number

Browse source 
When possible, we prefer to use the macro ARRAY_SIZE rather than hard
coding the number of elements.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200505123757.39506-12-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jérôme Pouiller 2020-05-05 14:37:53 +02:00 committed by Greg Kroah-Hartman
parent bcd8795ad2
commit 8371d215f4
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/wfx/data_tx.c
View file

@ -166,13 +166,13 @@ static int wfx_tx_policy_upload(struct wfx_vif *wvif)
do { do {
spin_lock_bh(&wvif->tx_policy_cache.lock); spin_lock_bh(&wvif->tx_policy_cache.lock);
for (i = 0; i < HIF_TX_RETRY_POLICY_MAX; ++i) { for (i = 0; i < ARRAY_SIZE(wvif->tx_policy_cache.cache); ++i) {
is_used = memzcmp(policies[i].rates, is_used = memzcmp(policies[i].rates,
sizeof(policies[i].rates)); sizeof(policies[i].rates));
if (!policies[i].uploaded && is_used) if (!policies[i].uploaded && is_used)
break; break;
} }
if (i < HIF_TX_RETRY_POLICY_MAX) { if (i < ARRAY_SIZE(wvif->tx_policy_cache.cache)) {
policies[i].uploaded = true; policies[i].uploaded = true;
memcpy(tmp_rates, policies[i].rates, sizeof(tmp_rates)); memcpy(tmp_rates, policies[i].rates, sizeof(tmp_rates));
spin_unlock_bh(&wvif->tx_policy_cache.lock); spin_unlock_bh(&wvif->tx_policy_cache.lock);
@ -180,7 +180,7 @@ static int wfx_tx_policy_upload(struct wfx_vif *wvif)
} else { } else {
spin_unlock_bh(&wvif->tx_policy_cache.lock); spin_unlock_bh(&wvif->tx_policy_cache.lock);
} }
} while (i < HIF_TX_RETRY_POLICY_MAX); } while (i < ARRAY_SIZE(wvif->tx_policy_cache.cache));
return 0; return 0;
} }
@ -204,7 +204,7 @@ void wfx_tx_policy_init(struct wfx_vif *wvif)
INIT_LIST_HEAD(&cache->used); INIT_LIST_HEAD(&cache->used);
INIT_LIST_HEAD(&cache->free); INIT_LIST_HEAD(&cache->free);
for (i = 0; i < HIF_TX_RETRY_POLICY_MAX; ++i) for (i = 0; i < ARRAY_SIZE(cache->cache); ++i)
list_add(&cache->cache[i].link, &cache->free); list_add(&cache->cache[i].link, &cache->free);
} }