mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
drivers/infiniband: replace open-coded string copy with get_task_comm
We'd better use the helper get_task_comm() rather than the open-coded strlcpy() to get task comm. As the comment above the hard-coded 16, we can replace it with TASK_COMM_LEN. Link: https://lkml.kernel.org/r/20211120112738.45980-4-laoar.shao@gmail.com Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com> Reviewed-by: David Hildenbrand <david@redhat.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com> Cc: Michal Miroslaw <mirq-linux@rere.qmqm.pl> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Matthew Wilcox <willy@infradead.org> Cc: David Hildenbrand <david@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Kees Cook <keescook@chromium.org> Cc: Petr Mladek <pmladek@suse.com> Cc: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
503471ac36
commit
7b6397d7e5
|
@ -196,7 +196,7 @@ struct qib_ctxtdata {
|
|||
pid_t pid;
|
||||
pid_t subpid[QLOGIC_IB_MAX_SUBCTXT];
|
||||
/* same size as task_struct .comm[], command that opened context */
|
||||
char comm[16];
|
||||
char comm[TASK_COMM_LEN];
|
||||
/* pkeys set by this use of this ctxt */
|
||||
u16 pkeys[4];
|
||||
/* so file ops can get at unit */
|
||||
|
|
|
@ -1321,7 +1321,7 @@ static int setup_ctxt(struct qib_pportdata *ppd, int ctxt,
|
|||
rcd->tid_pg_list = ptmp;
|
||||
rcd->pid = current->pid;
|
||||
init_waitqueue_head(&dd->rcd[ctxt]->wait);
|
||||
strlcpy(rcd->comm, current->comm, sizeof(rcd->comm));
|
||||
get_task_comm(rcd->comm, current);
|
||||
ctxt_fp(fp) = rcd;
|
||||
qib_stats.sps_ctxts++;
|
||||
dd->freectxts--;
|
||||
|
|
Loading…
Reference in a new issue