system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-16 08:19:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

locking/lockdep: Avoid constant checks in __bfs by using offset reference

Browse source 
In search of a dependency in the lock graph, there is contant checks for
forward or backward search. Directly reference the field offset of the
struct that differentiates the type of search to avoid those checks.

No functional change.

Signed-off-by: Yuyang Du <duyuyang@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bvanassche@acm.org
Cc: frederic@kernel.org
Cc: ming.lei@redhat.com
Cc: will.deacon@arm.com
Link: https://lkml.kernel.org/r/20190506081939.74287-15-duyuyang@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Yuyang Du 2019-05-06 16:19:30 +08:00 committed by Ingo Molnar
parent c166132559
commit 77a806922c
1 changed files with 21 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
kernel/locking/lockdep.c
View file

@ -1367,11 +1367,25 @@ static inline int get_lock_depth(struct lock_list *child)
return depth;
}
/*
* Return the forward or backward dependency list.
*
* @lock: the lock_list to get its class's dependency list
* @offset: the offset to struct lock_class to determine whether it is
* locks_after or locks_before
*/
static inline struct list_head *get_dep_list(struct lock_list *lock, int offset)
{
void *lock_class = lock->class;
return lock_class + offset;
}
static int __bfs(struct lock_list *source_entry,
void *data,
int (*match)(struct lock_list *entry, void *data),
struct lock_list **target_entry,
int forward)
int offset)
{
struct lock_list *entry;
struct lock_list *lock;
@ -1385,11 +1399,7 @@ static int __bfs(struct lock_list *source_entry,
goto exit;
}
if (forward)
head = &source_entry->class->locks_after;
else
head = &source_entry->class->locks_before;
head = get_dep_list(source_entry, offset);
if (list_empty(head))
goto exit;
@ -1403,10 +1413,7 @@ static int __bfs(struct lock_list *source_entry,
goto exit;
}
if (forward)
head = &lock->class->locks_after;
else
head = &lock->class->locks_before;
head = get_dep_list(lock, offset);
DEBUG_LOCKS_WARN_ON(!irqs_disabled());
@ -1439,7 +1446,8 @@ static inline int __bfs_forwards(struct lock_list *src_entry,
int (*match)(struct lock_list *entry, void *data),
struct lock_list **target_entry)
{
return __bfs(src_entry, data, match, target_entry, 1);
return __bfs(src_entry, data, match, target_entry,
offsetof(struct lock_class, locks_after));
}
@ -1448,7 +1456,8 @@ static inline int __bfs_backwards(struct lock_list *src_entry,
int (*match)(struct lock_list *entry, void *data),
struct lock_list **target_entry)
{
return __bfs(src_entry, data, match, target_entry, 0);
return __bfs(src_entry, data, match, target_entry,
offsetof(struct lock_class, locks_before));
}